public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: EDK II CI Phase 1 Unit Test Cases
Date: Thu, 7 Nov 2019 19:32:04 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9E00D7A@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E539639@SHSMSX104.ccr.corp.intel.com>

Hi Liming,

I have not done those cases.  I have cases that
modify existing files.  I want to make sure that these
test case are testing the Azure Pipelines, GitHub, and 
Mergify features.

Some of your suggestions are more about testing git
which seems out of scope.

I have submitted other PRs to edk2-ci that do 
add/remove/rename files without any issues.

However, a change to BaseTools is interesting, because
we would want to know that the modified version of
BaseTools is used to run the CI tests. I can add that
one.  Perhaps a change that generates extra log messages
so the extra log message can be found in the CI logs.

Mike

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Thursday, November 7, 2019 7:15 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: EDK II CI Phase 1 Unit Test Cases
> 
> Mike:
>   Is there the case to add new file or remove the
> existing file or rename the file name?
> 
>   And, is there the case to update BaseTools C or Python
> code?
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Michael
> > D Kinney
> > Sent: Thursday, November 7, 2019 10:07 AM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] EDK II CI Phase 1 Unit Test
> Cases
> >
> > Hello,
> >
> > The following link performs a query on the pull
> requests in
> > edk2-staging/edk2-ci branch that shows the unit tests
> cases that have
> > been run.
> >
> > https://github.com/tianocore/edk2-
> staging/pulls?utf8=%E2%9C%93&q=is%3A
> > pr+0005h+in%3Atitle+OR+0005+in%3Atitle
> >
> > It includes unit tests from maintainers and non-
> maintainers for patch
> > series that pass and fail the enabled checks and
> include the use of
> > the 'push' label by maintainers.
> >
> > Please review these unit test cases and provide
> feedback if there are
> > unit test cases that should be added or if any of
> these do not have
> > the expected results.
> >
> > These unit tests were run against the same sources
> that are under
> > review in the V4 patch series here:
> >
> > https://github.com/tianocore/edk2-staging/tree/edk2-
> ci_V4
> >
> > https://edk2.groups.io/g/devel/message/50126
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> > 


      reply	other threads:[~2019-11-07 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  2:06 EDK II CI Phase 1 Unit Test Cases Michael D Kinney
2019-11-07 15:15 ` Liming Gao
2019-11-07 19:32   ` Michael D Kinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9E00D7A@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox