From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.9448.1573155125632787388 for ; Thu, 07 Nov 2019 11:32:05 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 11:32:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,279,1569308400"; d="scan'208";a="192924646" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 07 Nov 2019 11:32:05 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 11:32:04 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX115.amr.corp.intel.com ([169.254.4.146]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 11:32:04 -0800 From: "Michael D Kinney" To: "Gao, Liming" , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: EDK II CI Phase 1 Unit Test Cases Thread-Topic: EDK II CI Phase 1 Unit Test Cases Thread-Index: AdWVDxEFLOd0IUM9Tu6SegwJ6hC1VQAbqy+gAAjii5A= Date: Thu, 7 Nov 2019 19:32:04 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E539639@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E539639@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, I have not done those cases. I have cases that modify existing files. I want to make sure that these test case are testing the Azure Pipelines, GitHub, and=20 Mergify features. Some of your suggestions are more about testing git which seems out of scope. I have submitted other PRs to edk2-ci that do=20 add/remove/rename files without any issues. However, a change to BaseTools is interesting, because we would want to know that the modified version of BaseTools is used to run the CI tests. I can add that one. Perhaps a change that generates extra log messages so the extra log message can be found in the CI logs. Mike > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 7, 2019 7:15 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: RE: EDK II CI Phase 1 Unit Test Cases >=20 > Mike: > Is there the case to add new file or remove the > existing file or rename the file name? >=20 > And, is there the case to update BaseTools C or Python > code? >=20 > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of Michael > > D Kinney > > Sent: Thursday, November 7, 2019 10:07 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Subject: [edk2-devel] EDK II CI Phase 1 Unit Test > Cases > > > > Hello, > > > > The following link performs a query on the pull > requests in > > edk2-staging/edk2-ci branch that shows the unit tests > cases that have > > been run. > > > > https://github.com/tianocore/edk2- > staging/pulls?utf8=3D%E2%9C%93&q=3Dis%3A > > pr+0005h+in%3Atitle+OR+0005+in%3Atitle > > > > It includes unit tests from maintainers and non- > maintainers for patch > > series that pass and fail the enabled checks and > include the use of > > the 'push' label by maintainers. > > > > Please review these unit test cases and provide > feedback if there are > > unit test cases that should be added or if any of > these do not have > > the expected results. > > > > These unit tests were run against the same sources > that are under > > review in the V4 patch series here: > > > > https://github.com/tianocore/edk2-staging/tree/edk2- > ci_V4 > > > > https://edk2.groups.io/g/devel/message/50126 > > > > Thanks, > > > > Mike > > > > > > > >=20