From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.9857.1573156947918861757 for ; Thu, 07 Nov 2019 12:02:28 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 12:02:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,279,1569308400"; d="scan'208";a="196673399" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga008.jf.intel.com with ESMTP; 07 Nov 2019 12:02:27 -0800 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 Nov 2019 12:02:27 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX121.amr.corp.intel.com ([169.254.10.88]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 12:02:26 -0800 From: "Michael D Kinney" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Wang, Jian J" Subject: Re: [Patch v4 11/22] MdeModulePkg: Add YAML file for CI builds Thread-Topic: [Patch v4 11/22] MdeModulePkg: Add YAML file for CI builds Thread-Index: AQHVlRftBGO+h6TBGk+cXB4JbskMA6eAIgHA Date: Thu, 7 Nov 2019 20:02:26 +0000 Message-ID: References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-12-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hao Wu, I agree that this duplicate GUID exception can be removed. I tried it out with a PR against edk2-staging/edk2-ci and=20 it passed all checks. https://github.com/tianocore/edk2-staging/pull/180 Mike > -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, November 6, 2019 7:03 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [Patch v4 11/22] MdeModulePkg: Add YAML > file for CI builds >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Thursday, November 07, 2019 9:14 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A > > Subject: [Patch v4 11/22] MdeModulePkg: Add YAML file > for CI builds > > > > Add YAML file to the package directory with the > configuration of the > > checks to perform during a CI build. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Signed-off-by: Michael D Kinney > > > --- > > MdeModulePkg/MdeModulePkg.ci.yaml | 81 > > +++++++++++++++++++++++++++++++ > > 1 file changed, 81 insertions(+) > > create mode 100644 MdeModulePkg/MdeModulePkg.ci.yaml > > > > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > > b/MdeModulePkg/MdeModulePkg.ci.yaml > > new file mode 100644 > > index 0000000000..6ae58d5379 > > --- /dev/null > > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > > @@ -0,0 +1,81 @@ > > +## > > +# CI configuration for MdeModulePkg > > +# > > +# Copyright (c) Microsoft Corporation # SPDX-License- > Identifier: > > +BSD-2-Clause-Patent ## { > > + ## options defined ci/Plugin/CompilerPlugin > > + "CompilerPlugin": { > > + "DscPath": "MdeModulePkg.dsc" > > + }, > > + > > + ## options defined ci/Plugin/CharEncodingCheck > > + "CharEncodingCheck": { > > + "IgnoreFiles": [] > > + }, > > + > > + ## options defined ci/Plugin/DependencyCheck > > + "DependencyCheck": { > > + "AcceptableDependencies": [ > > + "MdePkg/MdePkg.dec", > > + "MdeModulePkg/MdeModulePkg.dec", > > + "StandaloneMmPkg/StandaloneMmPkg.dec", > > + "ArmPkg/ArmPkg.dec" # this should be > fixed by promoting > > + an > > abstraction > > + ], > > + # For host based unit tests > > + "AcceptableDependencies-HOST_APPLICATION":[], > > + # For UEFI shell based apps > > + "AcceptableDependencies-UEFI_APPLICATION":[], > > + "IgnoreInf": [] > > + }, > > + > > + ## options defined ci/Plugin/DscCompleteCheck > > + "DscCompleteCheck": { > > + "IgnoreInf": [], > > + "DscPath": "MdeModulePkg.dsc" > > + }, > > + > > + ## options defined ci/Plugin/GuidCheck > > + "GuidCheck": { > > + "IgnoreGuidName": [], > > + "IgnoreGuidValue": ["00000000-0000-0000-0000- > 000000000000"], > > + "IgnoreFoldersAndFiles": [], > > + "IgnoreDuplicates": [ > > + > > > "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtoc > olGuid", > > + > "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > > + > "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid", > > + "gEdkiiSerialPortLibVendorGuid=3DSerialDxe" > # Is this a bug???? >=20 >=20 > Hello Mike, >=20 > I think the above GUID duplication (serial-related) has > already been addressed via commits: >=20 > SHA-1: 0d85e67714e31e0dbe4241ab2ebb7c423aba174d > * MdeModulePkg/SerialDxe: Update the file Guid in > SerialDxe.inf >=20 > SHA-1: 9790f62be1aa5ee9460d4c4ec8c720919523bb62 > * MdeModulePkg SerialDxe.inf: Fix wrong FILE_GUID format >=20 > Could you help to confirm whether the item can be > removed? >=20 > With it handled, > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > + ] > > + }, > > + > > + ## options defined ci/Plugin/LibraryClassCheck > > + "LibraryClassCheck": { > > + "IgnoreHeaderFile": [] > > + }, > > + > > + ## options defined ci/Plugin/SpellCheck > > + "SpellCheck": { > > + "AuditOnly": True, # Fails test but > run in AuditOnly mode to collect > > log > > + "IgnoreStandardPaths": [ # Standard > Plugin defined paths that should > > be ignore > > + "*.c", "*.asm", "*.h", "*.nasm", "*.s", > "*.asl", "*.inf" > > + ], > > + "IgnoreFiles": [ # use gitignore > syntax to ignore errors in matching > > files > > + > "Library/LzmaCustomDecompressLib/Sdk/DOC/*" > > + ], > > + "ExtendWords": [ # words to extend > to the dictionary for this > > package > > + "LIGHTGRAY", > > + "DARKGRAY", > > + "LIGHTBLUE", > > + "LIGHTGREEN", > > + "LIGHTCYAN", > > + "LIGHTRED", > > + "LIGHTMAGENTA", > > + "FVMAIN", > > + "VARCHECKPCD", > > + "Getxx", > > + "lzturbo" > > + ], > > + "AdditionalIncludePaths": [] # Additional > paths to spell > > + check relative to > > package root (wildcards supported) > > + } > > +} > > -- > > 2.21.0.windows.1