From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate
Date: Fri, 8 Nov 2019 17:10:04 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9E012B3@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <5ccaa1d4-714d-f785-e57d-bbd2c8e4596e@redhat.com>
Phil,
Yes. There are two methods available
1) You can run the CI tests on your local dev system.
Fix issues locally and rerun as needed before sending
patch review email. This will only perform build
tests with your local compiler.
2) You can push a branch with changes to your personal
fork of the edk2 repository (edk2-staging in the
review period) and submit a pull request to the
tianocore repo *without* the 'push' label set . This
is considered a personal build. If all CI checks pass
then the PR is auto closed with a comment on the
PR. If the PR fails, then the PR is left open with
comment on the PR. In the failure case, you can fix
the issue on your local branch and do a forced
push to your personal fork. GitHub sees the forced
push and reruns the CI tests automatically. Today
this runs build tests for VS2019 and GCC, so you get
better coverage than local testing. Once your personal
build passes, you can send patch review email and can
even point to the PR for your personal build so
reviewers and maintainers can view the CI results.
NOTE: (1) does not send any public emails.
(2) will send a public email when a comment or
close action is performed on a PR to all
GitHub users that are watching that repo.
Best regards,
Mike
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Friday, November 8, 2019 6:49 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] EDK II Maintainers please test
> the pull request commit gate
>
> Hi Michael,
>
> On 11/7/19 3:24 AM, Michael D Kinney wrote:
> > EDK II Maintainers,
> >
> > Please take a few minutes to test the GitHub pull
> request commit gate
> > feature under review in the edk2-staging/edk2-ci
> branch. This will be
> > the only method to push patches to the edk2 repo in
> the near future,
> > and we want all current EDK II Maintainers to make
> sure they know how
> > to use this new process on the edk2-staging repo
> before it is
> > activated on the
> > edk2 repo.
> [...]
>
> Is it possible to use the CI gating scripts on an
> individual fork when working on a new feature, so if the
> CI system catches bugs we can fix them before bothering
> the mailing list and maintainers for review?
>
> Thanks,
>
> Phil.
next prev parent reply other threads:[~2019-11-08 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney
2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek
2019-11-07 15:18 ` Liming Gao
2019-11-07 19:33 ` Michael D Kinney
2019-11-07 19:26 ` Michael D Kinney
2019-11-08 17:12 ` Laszlo Ersek
2019-11-08 17:21 ` Michael D Kinney
2019-11-08 14:49 ` Philippe Mathieu-Daudé
2019-11-08 17:10 ` Michael D Kinney [this message]
2019-11-08 17:43 ` rebecca
2019-11-11 5:42 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9E012B3@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox