From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.1304.1574881412308063039 for ; Wed, 27 Nov 2019 11:03:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 11:03:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,250,1571727600"; d="scan'208";a="410447168" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga006.fm.intel.com with ESMTP; 27 Nov 2019 11:03:22 -0800 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 11:03:22 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.200]) by ORSMSX158.amr.corp.intel.com ([169.254.10.131]) with mapi id 14.03.0439.000; Wed, 27 Nov 2019 11:03:22 -0800 From: "Michael D Kinney" To: Laszlo Ersek , "devel@edk2.groups.io" , Sean Brogan , "Bret Barkelew" , "Gao, Liming" , "Kinney, Michael D" Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master Thread-Topic: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master Thread-Index: AdWY/xjw4dZ1iskvSlK5J8Hop+ZpewLdrbAAADbisuA= Date: Wed, 27 Nov 2019 19:03:22 +0000 Message-ID: References: <545f1da9-a998-1095-57f9-085cbd535596@redhat.com> In-Reply-To: <545f1da9-a998-1095-57f9-085cbd535596@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, Do you want to see the presence of the 'push' label in a notification when the PR is created, or just when the checks have been completed in either the pass or the fail state? A PR may be created initially without the 'push' label. The EDK II Maintainer can resolve any issues in that PR using forced pushes to restart the checks with the=20 issues resolved. When all check pass, the maintainer can then set the 'push' label and re-open the PR. Then the checks will run again and the PR will be merged. In this use case what email notifications would you like to see? Thanks, Mike > -----Original Message----- > From: Laszlo Ersek > Sent: Tuesday, November 26, 2019 12:23 AM > To: devel@edk2.groups.io; Kinney, Michael D > ; Sean Brogan > ; Bret Barkelew > ; Gao, Liming > > Subject: Re: [edk2-devel] EDK II Maintainers - EDK II > CI is now active on edk2/master >=20 > Hi Mike, >=20 > On 11/12/19 03:55, Michael D Kinney wrote: > > EDK II Maintainers, > > > > EDK II CI Phase 1 feature is now active on > edk2/master. > > > > Please use a GitHub pull request from a branch in a > personal fork of > > the edk2 repository with a 'push' label to request a > set of patches to > > be pushed to edk2/master. The GitHub PR replaces the > 'git push' > > operation currently used to commit changes to > edk2/master. > > > > You will need to configure your notifications from > the edk2 repository > > to make sure you receive email notifications when the > checks against > > the GitHub PR passes or fails. > > > > If you submit a GitHub Pull Request without the > 'push' > > label, then the CI checks are run and the results are > generated. > > > > Please let us know if there are any questions about > this change in the > > development process. >=20 > I think this workflow feature has been working well; > thank you (and everyone else involved) again for > implementing it. >=20 > Having read a good number of the emails sent out by > github.com about such Pull Requests, I'd like to > request a new feature, or at least to suggest a usage > convention. >=20 > The presence of the "push" label decides whether the PR > is actually meant for master, or if it's a personal > build (usually employed as a sanity check before > posting a series to the list for review). >=20 > This difference is important, but there is no sign of > the "push" label (or of its absence) in the emails that > github.com generates, as far as I can tell. Right now I > can only tell the difference from the final mergify bot > comment that says >=20 > - "Merged #197 into master." >=20 > versus >=20 > - "All checks passed. Auto close personal build." >=20 > Can we please > - either tweak github.com to include any labels that > are tacked to the PR, in the notification emails, > - or adopt a convention where "personal build" PRs are > required to state that fact in the PR title? >=20 > Thanks! > Laszlo