From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.12388.1575564537705280176 for ; Thu, 05 Dec 2019 08:48:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 08:48:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,282,1571727600"; d="scan'208";a="214232960" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2019 08:48:57 -0800 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Dec 2019 08:48:56 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.200]) by ORSMSX160.amr.corp.intel.com ([169.254.13.204]) with mapi id 14.03.0439.000; Thu, 5 Dec 2019 08:48:56 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Feng, Bob C" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build Thread-Topic: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build Thread-Index: AQHVq0Sz0nvlP63htEmOhWMP6NGoBqerwLgg Date: Thu, 5 Dec 2019 16:48:55 +0000 Message-ID: References: <20191205081807.15092-1-bob.c.feng@intel.com> In-Reply-To: <20191205081807.15092-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob, How does a tool chain opt-in or opt-out of this feature? As you point out, not all tool chains provide the information needed to support this feature. We need to make sure the=20 use of this feature or not is clearly documented in the=20 profile for each tool chain. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Bob Feng > Sent: Thursday, December 5, 2019 12:18 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/4 V4] Enhance > Incremental Build >=20 > V4: Move .deps files to where corresponding .obj file > locate > V3: Change CLANG9 to CLANGPDB according to commit > 14672c34bd > V2: Fixed a bug in patch 4/4. >=20 > Incremental build reduces the build time by only > building > the module that need to update. Edk2 Build system is a > Makefile > based build system. The incrememtal build ability is > provided by > the Make program. But Edk2 build tool need to generate > correct makefile > to have Make program do incremental build correctly. >=20 > The current solution in build tool to support > incremental build is that build > tool find out the include file list for each source > file of a module, and in module's > makefile, build tool add the include file list as the > source file's dependency. > In this way Make program can decide if it need to > rebuild a source code by checking > its dependency. This solution has 2 shortcommings, one > is the process of finding > include list is slow, the other is this method can't > handle case that > a MACRO in #include statement so the related source > file is always built. >=20 > This patch provides another method to support > incremental build. That is to use > c preprocessor and trim tool to generate dependency > files for the source file. > This method will save much time in AutoGen phase and > handle MACRO in #include correctly. >=20 > For C files: > 1. MSVS. > cl.exe has a build option /showIncludes to > display include files on stdout. Build tool captures > that messages and generate dependency files, > .deps files. > 2. CLANG and GCC > -MMD -MF build option are used to generate > dependency files by preprocessor. Build tool updates > the > .deps files. >=20 > For ASL files: > 1. Trim find out all the included files, which are > asl specific include format, and generate .trim.deps > file. > 2. ASL PP use c preprocessor to find out all > included files with #include format and generate a > .deps file > 3. build tool updates the .deps file >=20 > For ASM files (.asm, .s or .nasm): > 1. Trim find out all the included files, which are > asm specific include format, and generate .trim.deps > file. > 2. ASM PP use c preprocessor to find out all > included files with #include format and generate a deps > file > 3. build tool updates the .deps file >=20 > Build tool add "include" instruction for those deps > files in the Makefile. >=20 > This patch does not support RVCT tool chain for the BZ > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 >=20 > Feng, Bob C (4): > BaseTools: Add build option for dependency file > generation > BaseTools: Generate dependent files for ASL and ASM > files > BaseTools: Update build_rule.txt to generate > dependent files. > BaseTools: Enhance Basetool for incremental build >=20 > BaseTools/Conf/build_rule.template | 94 > ++++--- > BaseTools/Conf/tools_def.template | 173 > ++++++------ > BaseTools/Source/Python/AutoGen/GenMake.py | 83 > ++---- > .../Source/Python/AutoGen/IncludesAutoGen.py | 255 > ++++++++++++++++++ > .../Source/Python/AutoGen/ModuleAutoGen.py | 23 ++ > BaseTools/Source/Python/Trim/Trim.py | 115 > ++++++-- > BaseTools/Source/Python/build/build.py | 63 > ++++- > 7 files changed, 588 insertions(+), 218 deletions(-) > create mode 100644 > BaseTools/Source/Python/AutoGen/IncludesAutoGen.py >=20 > -- > 2.20.1.windows.1 >=20 >=20 >=20