From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.8273.1575603345616058955 for ; Thu, 05 Dec 2019 19:35:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 19:35:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,282,1571727600"; d="scan'208";a="214385503" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2019 19:35:44 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 5 Dec 2019 19:35:44 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.200]) by ORSMSX157.amr.corp.intel.com ([169.254.9.64]) with mapi id 14.03.0439.000; Thu, 5 Dec 2019 19:35:44 -0800 From: "Michael D Kinney" To: "Feng, Bob C" , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build Thread-Topic: [edk2-devel] [Patch 0/4 V4] Enhance Incremental Build Thread-Index: AQHVq0Sz0nvlP63htEmOhWMP6NGoBqerwLgggAEMcQD//6ifsA== Date: Fri, 6 Dec 2019 03:35:44 +0000 Message-ID: References: <20191205081807.15092-1-bob.c.feng@intel.com> <08650203BA1BD64D8AD9B6D5D74A85D16157C357@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16157C357@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Feng, Bob C > Sent: Thursday, December 5, 2019 4:48 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [edk2-devel] [Patch 0/4 V4] Enhance > Incremental Build >=20 > Hi Mike, >=20 > A tool chain enable this feature by defining the > *__*_DEPS_FLAGS in tools_def and > applying $(DEPS_FLAGS) in build_rule.txt. > I have added those setting for MSVC, GCC, CLANG tool > chain in tools_def.template and build_rule.template. > Those exist tool chains are all enable this feature by > default. >=20 > Only RVCT tool chain does not support this feature, but > according to > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750, > RVCT will be dropped from our support tool chains. >=20 > So is it fine to add comments for each tool chain to > document this tool chain is enabled to generate > dependency files in build_rule.template? Do you mean tools_def.template? Then yes. >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, December 6, 2019 12:49 AM > To: devel@edk2.groups.io; Feng, Bob C > ; Kinney, Michael D > > Subject: RE: [edk2-devel] [Patch 0/4 V4] Enhance > Incremental Build >=20 > Hi Bob, >=20 > How does a tool chain opt-in or opt-out of this > feature? >=20 > As you point out, not all tool chains provide the > information needed to support this feature. We need to > make sure the use of this feature or not is clearly > documented in the profile for each tool chain. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of Bob > > Feng > > Sent: Thursday, December 5, 2019 12:18 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [Patch 0/4 V4] Enhance > Incremental Build > > > > V4: Move .deps files to where corresponding .obj file > locate > > V3: Change CLANG9 to CLANGPDB according to commit > 14672c34bd > > V2: Fixed a bug in patch 4/4. > > > > Incremental build reduces the build time by only > building the module > > that need to update. Edk2 Build system is a Makefile > based build > > system. The incrememtal build ability is provided by > the Make program. > > But Edk2 build tool need to generate correct makefile > to have Make > > program do incremental build correctly. > > > > The current solution in build tool to support > incremental build is > > that build tool find out the include file list for > each source file of > > a module, and in module's makefile, build tool add > the include file > > list as the source file's dependency. > > In this way Make program can decide if it need to > rebuild a source > > code by checking its dependency. This solution has 2 > shortcommings, > > one is the process of finding include list is slow, > the other is this > > method can't handle case that a MACRO in #include > statement so the > > related source file is always built. > > > > This patch provides another method to support > incremental build. That > > is to use c preprocessor and trim tool to generate > dependency files > > for the source file. > > This method will save much time in AutoGen phase and > handle MACRO in > > #include correctly. > > > > For C files: > > 1. MSVS. > > cl.exe has a build option /showIncludes to > display include > > files on stdout. Build tool captures > > that messages and generate dependency files, > .deps files. > > 2. CLANG and GCC > > -MMD -MF build option are used to generate > dependency files by > > preprocessor. Build tool updates the > > .deps files. > > > > For ASL files: > > 1. Trim find out all the included files, which > are asl specific > > include format, and generate .trim.deps file. > > 2. ASL PP use c preprocessor to find out all > included files with > > #include format and generate a .deps file > > 3. build tool updates the .deps file > > > > For ASM files (.asm, .s or .nasm): > > 1. Trim find out all the included files, which > are asm specific > > include format, and generate .trim.deps file. > > 2. ASM PP use c preprocessor to find out all > included files with > > #include format and generate a deps file > > 3. build tool updates the .deps file > > > > Build tool add "include" instruction for those deps > files in the > > Makefile. > > > > This patch does not support RVCT tool chain for the > BZ > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1750 > > > > Feng, Bob C (4): > > BaseTools: Add build option for dependency file > generation > > BaseTools: Generate dependent files for ASL and ASM > files > > BaseTools: Update build_rule.txt to generate > dependent files. > > BaseTools: Enhance Basetool for incremental build > > > > BaseTools/Conf/build_rule.template | 94 > > ++++--- > > BaseTools/Conf/tools_def.template | 173 > > ++++++------ > > BaseTools/Source/Python/AutoGen/GenMake.py | 83 > > ++---- > > .../Source/Python/AutoGen/IncludesAutoGen.py | 255 > > ++++++++++++++++++ > > .../Source/Python/AutoGen/ModuleAutoGen.py | 23 > ++ > > BaseTools/Source/Python/Trim/Trim.py | 115 > > ++++++-- > > BaseTools/Source/Python/build/build.py | 63 > > ++++- > > 7 files changed, 588 insertions(+), 218 deletions(-) > create mode > > 100644 > BaseTools/Source/Python/AutoGen/IncludesAutoGen.py > > > > -- > > 2.20.1.windows.1 > > > > > >=20