public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Rabeda, Maciej" <maciej.rabeda@intel.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	Maciej Rabeda <maciej.rabeda@linux.intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address
Date: Tue, 10 Dec 2019 18:27:30 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9E39A86@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <4f871fba-6347-e0d0-20ce-bfef476a3f05@redhat.com>

Hi Maciej,

Once a patch review is complete that updates Maintainers.txt
with a new maintainer, one of the existing maintainers should
submit a PR to get Maintainer.txt updated in edk2/master.  In
the corner case where none of the existing maintainers are 
available to submit this PR, one of the stewards can support 
this PR.

At that point, the new maintainer needs to be added to the
TianoCore EDK II Maintainers Team so the new maintainer has 
The ability to set the 'push' label on PRs they want merged
into edk2/master.

The new maintainer should send an email to the mailing list 
requesting membership in the TianoCore EDK II Maintainers team.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Laszlo Ersek
> Sent: Tuesday, December 10, 2019 10:17 AM
> To: Rabeda, Maciej <maciej.rabeda@intel.com>;
> devel@edk2.groups.io; Wu, Jiaxin <jiaxin.wu@intel.com>;
> Maciej Rabeda <maciej.rabeda@linux.intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Cc: Fu, Siyuan <siyuan.fu@intel.com>
> Subject: Re: [edk2-devel] [PATCH] Maintainers.txt:
> Update reviewer email address
> 
> On 12/10/19 19:15, Laszlo Ersek wrote:
> > On 12/10/19 16:01, Rabeda, Maciej wrote:
> >> Laszlo,
> >>
> >> Thanks for a thorough explanation of the process :)
> >> It looks like one extra step for maintainership
> transition seems is identified:
> >> "However (AIUI), the mergify bot will reject and
> close any PR with the "push" label set if the PR was
> not submitted by a maintainer in the first place"
> >>
> >> For maintainer identification process, where does
> the mergify bot get the maintainer list from?
> >
> > I *think* it is represented through membership in the
> "tianocore"
> > organization on github.com.
> >
> >   https://github.com/orgs/tianocore/people
> >
> > I'm not sure but I imagine different people could
> have different
> > permissions associated with them, in this org.
> 
> Seems like there is a subgroup (?) called
> "tianocore/edk-ii-maintainers".
> 
> Thanks
> Laszlo
> 
> >> Do you know who should I ask to be added to that
> list?
> >
> > If I remember correctly, Mike can manage such
> memberships / rights.
> >
> > Thanks!
> > Laszlo
> >
> 
> 
> 


  reply	other threads:[~2019-12-10 18:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 16:28 [PATCH] Maintainers.txt: Update reviewer email address Maciej Rabeda
2019-12-10  5:37 ` Wu, Jiaxin
2019-12-10  8:35   ` [edk2-devel] " Rabeda, Maciej
2019-12-10  9:10     ` Laszlo Ersek
2019-12-10  9:32       ` Rabeda, Maciej
2019-12-10 12:36         ` Laszlo Ersek
2019-12-10 15:01           ` Rabeda, Maciej
2019-12-10 18:15             ` Laszlo Ersek
2019-12-10 18:16               ` Laszlo Ersek
2019-12-10 18:27                 ` Michael D Kinney [this message]
2019-12-10 22:05                   ` Rabeda, Maciej
2019-12-10 10:27       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9E39A86@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox