From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.1051.1576002452210941348 for ; Tue, 10 Dec 2019 10:27:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2019 10:27:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,300,1571727600"; d="scan'208";a="215525100" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga006.jf.intel.com with ESMTP; 10 Dec 2019 10:27:31 -0800 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 10:27:31 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.100]) by ORSMSX116.amr.corp.intel.com ([169.254.7.30]) with mapi id 14.03.0439.000; Tue, 10 Dec 2019 10:27:31 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Rabeda, Maciej" , "Wu, Jiaxin" , Maciej Rabeda , "Gao, Liming" , "Kinney, Michael D" CC: "Fu, Siyuan" Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Thread-Topic: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Thread-Index: AQHVrFJMe0DIlkoxHky5JqS4Hom2oaezZWKAgAAxlACAAAnwAIAABi8AgAAzWYCAAChdgIAANjgAgAAAYID//3r/AA== Date: Tue, 10 Dec 2019 18:27:30 +0000 Message-ID: References: <20191206162855.2155-1-maciej.rabeda@linux.intel.com> <895558F6EA4E3B41AC93A00D163B727416FBF2B4@SHSMSX107.ccr.corp.intel.com> <077c152f-22f8-ce29-ccaa-10874d5e8381@redhat.com> <4f871fba-6347-e0d0-20ce-bfef476a3f05@redhat.com> In-Reply-To: <4f871fba-6347-e0d0-20ce-bfef476a3f05@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Maciej, Once a patch review is complete that updates Maintainers.txt with a new maintainer, one of the existing maintainers should submit a PR to get Maintainer.txt updated in edk2/master. In the corner case where none of the existing maintainers are=20 available to submit this PR, one of the stewards can support=20 this PR. At that point, the new maintainer needs to be added to the TianoCore EDK II Maintainers Team so the new maintainer has=20 The ability to set the 'push' label on PRs they want merged into edk2/master. The new maintainer should send an email to the mailing list=20 requesting membership in the TianoCore EDK II Maintainers team. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Laszlo Ersek > Sent: Tuesday, December 10, 2019 10:17 AM > To: Rabeda, Maciej ; > devel@edk2.groups.io; Wu, Jiaxin ; > Maciej Rabeda ; Kinney, > Michael D ; Gao, Liming > > Cc: Fu, Siyuan > Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: > Update reviewer email address >=20 > On 12/10/19 19:15, Laszlo Ersek wrote: > > On 12/10/19 16:01, Rabeda, Maciej wrote: > >> Laszlo, > >> > >> Thanks for a thorough explanation of the process :) > >> It looks like one extra step for maintainership > transition seems is identified: > >> "However (AIUI), the mergify bot will reject and > close any PR with the "push" label set if the PR was > not submitted by a maintainer in the first place" > >> > >> For maintainer identification process, where does > the mergify bot get the maintainer list from? > > > > I *think* it is represented through membership in the > "tianocore" > > organization on github.com. > > > > https://github.com/orgs/tianocore/people > > > > I'm not sure but I imagine different people could > have different > > permissions associated with them, in this org. >=20 > Seems like there is a subgroup (?) called > "tianocore/edk-ii-maintainers". >=20 > Thanks > Laszlo >=20 > >> Do you know who should I ask to be added to that > list? > > > > If I remember correctly, Mike can manage such > memberships / rights. > > > > Thanks! > > Laszlo > > >=20 >=20 >=20