Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Vitaly,

Is the use case for UEFI Applications?

There is a different mechanism to disable all ASSERT()
statements  within a UEFI Application.

If a component is consuming data from an untrusted source,
then that component is required to verify the untrusted 
data before passing it to a function that clearly documents
is input requirements.  If this approach is followed, then
the BaseLib functions can be used "as is" as long as the 
ASSERT() conditions are verified before calling.

If there are some APIs that currently document their ASSERT()
behavior and we think that ASSERT() behavior is incorrect and
should be handled by an existing error return value, then we
should discuss each of those APIs individually.

Mike


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Vitaly Cheptsov via Groups.Io
> Sent: Friday, January 3, 2020 9:13 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v3 0/1] Add PCD to disable
> safe string constraint assertions
> 
> REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2054
> 
> Requesting for merge in edk2-stable202002.
> 
> Changes since V1:
> - Enable assertions by default to preserve the original
> behaviour
> - Fix bugzilla reference link
> - Update documentation in BaseLib.h
> 
> Vitaly Cheptsov (1):
>   MdePkg: Add PCD to disable safe string constraint
> assertions
> 
>  MdePkg/MdePkg.dec                   |  6 ++
>  MdePkg/Library/BaseLib/BaseLib.inf  | 11 +--
>  MdePkg/Include/Library/BaseLib.h    | 74
> +++++++++++++-------
>  MdePkg/Library/BaseLib/SafeString.c |  4 +-
>  MdePkg/MdePkg.uni                   |  6 ++
>  5 files changed, 71 insertions(+), 30 deletions(-)
> 
> --
> 2.21.0 (Apple Git-122.2)
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this
> group.
> 
> View/Reply Online (#52837):
> https://edk2.groups.io/g/devel/message/52837
> Mute This Topic: https://groups.io/mt/69401948/1643496
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [michael.d.kinney@intel.com]
> -=-=-=-=-=-=