From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.2520.1579136141883611824 for ; Wed, 15 Jan 2020 16:55:41 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 16:55:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,323,1574150400"; d="scan'208";a="423815285" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga005.fm.intel.com with ESMTP; 15 Jan 2020 16:55:41 -0800 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 16:55:41 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.100]) by ORSMSX112.amr.corp.intel.com ([169.254.3.41]) with mapi id 14.03.0439.000; Wed, 15 Jan 2020 16:55:40 -0800 From: "Michael D Kinney" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" Subject: Re: [PATCH v3 0/1] SecurityPkg/BaseHashLib: Implement Unified Hash Calculation API Thread-Topic: [PATCH v3 0/1] SecurityPkg/BaseHashLib: Implement Unified Hash Calculation API Thread-Index: AQHVy/cvAOJdNme+tUqAppRUJtsJEKfsZRsggAAH+jCAAAmqIA== Date: Thu, 16 Jan 2020 00:55:39 +0000 Message-ID: References: <20200115225730.1330-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Amol, Add a PCD to CryptoPkg. There are other CryptoPkg extensions I am working on=20 that will also define a PCD. When you build your code and disassemble, are all the hash algorithms included even through a module only=20 needs one? The design I have in mind allows unused=20 hash services to always be optimized away. Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Wednesday, January 15, 2020 4:48 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Sukerkar, Amol N > > Subject: RE: [PATCH v3 0/1] SecurityPkg/BaseHashLib: > Implement Unified Hash Calculation API >=20 > Hi Mike, >=20 > This design does not implement any registration. The > hashing algorithm is selected from the array index > specified by PcdSystemHashPolicy value, just like > switch..case, based on recommendation by Jian. Are you > referring to the document attached to Bugzilla ticket > mentioned below? I plan to update it as soon as we > agree on the final design. Apologies if it was > misleading today. >=20 > The reason this lib was added to SecurityPkg and not > CryptoPkg was done because the decision to choose > hashing algorithm is based on PCD, PcdSystemHashPolicy. > CryptoPkg only provides API for accessing specific > hashing algorithm and there is no mechanism to choose, > as there is no precedent to using a PCD in CryptoPkg > and it does not look like that needs to change. On the > other hand, we actually do have API support in > SecurityPkg (HashInstanceLib). Our design provides > similar API support, although, it is much simpler and > does not involve registration as in HashInstanceLib. Do > you still think this lib should be implemented in > CryptoPkg? If yes, how do you propose the user choose > the desired hashing mechanism? >=20 > Thanks, > Amol >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, January 15, 2020 4:52 PM > To: Sukerkar, Amol N ; > devel@edk2.groups.io; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > > Subject: RE: [PATCH v3 0/1] SecurityPkg/BaseHashLib: > Implement Unified Hash Calculation API >=20 > Amol, >=20 > I still think the handle based registration is too > complex for this feature. >=20 > I recommend a simpler lib design and add it to > CryptoPkg instead of SecurityPkg. Providing a > different method to access the hashing functions in > BaseCryptLib is not a Security feature, it is a Crypto > feature. >=20 > Thanks, >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Sukerkar, Amol N > > Sent: Wednesday, January 15, 2020 2:57 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; > Yao, Jiewen > > ; Wang, Jian J > ; Agrawal, > > Sachin ; Musti, Srinivas > > ; Lakkimsetti, Subash > > > > Subject: [PATCH v3 0/1] SecurityPkg/BaseHashLib: > > Implement Unified Hash Calculation API > > > > Currently, the UEFI drivers using the SHA/SM3 hashing > algorithms use > > hard-coded API to calculate the hash, for instance, > sha_256(...), etc. > > Since SHA384 and/or > > SM3_256 are being increasingly adopted for > robustness, it becomes > > cumbersome to modify each driver that calls into hash > calculating API. > > > > To better achieve this, we are proposing a Unified > API, which can be > > used by UEFI drivers, that provides the drivers with > flexibility to > > use the desired hashing algorithm based on the > required robnustness. > > > > Alternatively, the design document is also attached > to Bugzilla, > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. > > > > Sukerkar, Amol N (1): > > SecurityPkg/BaseHashLib: Implement Unified Hash > Calculation API > > > > SecurityPkg/Library/BaseHashLib/BaseHashLibCommon.c > | > > 151 ++++++++++++++++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.c > | > > 100 +++++++++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.c > | > > 103 +++++++++++++ > > SecurityPkg/Include/Library/BaseHashLib.h > | > > 85 +++++++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibCommon.h > | > > 141 ++++++++++++++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.inf > | > > 46 ++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.uni > | > > 17 +++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.inf > | > > 51 +++++++ > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.uni > | > > 16 +++ > > SecurityPkg/SecurityPkg.dec > | > > 23 ++- > > SecurityPkg/SecurityPkg.dsc > | > > 10 +- > > SecurityPkg/SecurityPkg.uni > | > > 15 +- > > 12 files changed, 755 insertions(+), 3 deletions(-) > create mode > > 100644 > SecurityPkg/Library/BaseHashLib/BaseHashLibCommon.c > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.c > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.c > > create mode 100644 > > SecurityPkg/Include/Library/BaseHashLib.h > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibCommon.h > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.inf > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibDxe.uni > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.inf > > create mode 100644 > > SecurityPkg/Library/BaseHashLib/BaseHashLibPei.uni > > > > -- > > 2.16.2.windows.1 >=20 >=20