Re: [PATCH v6 0/2] CryptoPkg/HashApiLib: Implement Unified Hash Calculation API

["Michael D Kinney" <michael.d.kinney@intel.com>]

Amol,


1) Typo in CryptoPkg.dec.  Should be Crypto Package, not Security package.

  [Guids]
    ## Security package token space guid.

2) CryptoPkg.dec/uni.  I see the default value for PcdHashApiLibPolicy
   is 0x04.  This is documented to be SHA256.  The DEC/UNI file
   descriptions of this PCD should state that the default policy is
   SHA256.  This makes it clear to platform developers that maintain
   DSC files what the default policy is.

3) CryptoPkg.dsc: The same HashApiLib instance is used for all module types
   so a single mapping can be moved to [LibraryClasses] section and the
   DSC file and removed from the [LibraryClass.common.<ModuleType>] sections.

4) The name of the HashApiLib instance should be "BaseHashApiLib" and the
   should be in the CryptoPkg/Library/BaseHashApiLib directory with
   files BashHashApiLib.inf, BaseHashApiLib.c, and BaseHashApiLib.uni.
   BASE_NAME in BaseHashApiLib.iunf should also be BaseHashApiLib.

5) In order to be consistent with other EDK II context typedefs, I recommend

	typedef VOID  *HASH_API_CONTEXT;

   Also update APIs to use HashContext instead of *HashContext.

6) HashApiDuplicate() - The NewHashContext parameter should be type
   HASH_API_CONTEXT.

7) HashApiLib.inf - I think you can remove MdeModulePkg.dec from [Packages]

Thanks,

Mike

> -----Original Message-----
> From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Sent: Tuesday, January 28, 2020 10:04 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Agrawal, Sachin
> <sachin.agrawal@intel.com>; Musti, Srinivas
> <srinivas.musti@intel.com>; Lakkimsetti, Subash
> <subash.lakkimsetti@intel.com>
> Subject: [PATCH v6 0/2] CryptoPkg/HashApiLib: Implement
> Unified Hash Calculation API
> 
> Currently, the UEFI drivers using the SHA/SM3 hashing
> algorithms use hard-coded
> API to calculate the hash, for instance, sha_256(...),
> etc. Since SHA384 and/or
> SM3_256 are being increasingly adopted for robustness,
> it becomes cumbersome to
> modify each driver that calls into hash calculating API.
> 
> To better achieve this, we are proposing a Unified API,
> which can be used by UEFI
> drivers, that provides the drivers with flexibility to
> use the desired hashing
> algorithm based on the required robnustness.
> 
> Alternatively, the design document is also attached to
> Bugzilla,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2151.
> 
> Sukerkar, Amol N (2):
>   CryptoPkg: Add CryptoPkg Token Space GUID
>   CryptoPkg/HashApiLib: Implement Unified Hash
> Calculation API
> 
>  CryptoPkg/Library/HashApiLib/HashApiLib.c   | 333
> ++++++++++++++++++++
>  CryptoPkg/CryptoPkg.dec                     |  27 +-
>  CryptoPkg/CryptoPkg.dsc                     |   7 +-
>  CryptoPkg/CryptoPkg.uni                     |  17 +
>  CryptoPkg/Include/Library/HashApiLib.h      | 122
> +++++++
>  CryptoPkg/Library/HashApiLib/HashApiLib.inf |  45 +++
>  CryptoPkg/Library/HashApiLib/HashApiLib.uni |  17 +
>  7 files changed, 566 insertions(+), 2 deletions(-)
>  create mode 100644
> CryptoPkg/Library/HashApiLib/HashApiLib.c
>  create mode 100644
> CryptoPkg/Include/Library/HashApiLib.h
>  create mode 100644
> CryptoPkg/Library/HashApiLib/HashApiLib.inf
>  create mode 100644
> CryptoPkg/Library/HashApiLib/HashApiLib.uni
> 
> --
> 2.16.2.windows.1