From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.35.1580328616619974156 for ; Wed, 29 Jan 2020 12:10:16 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 12:10:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,379,1574150400"; d="scan'208";a="277613356" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 29 Jan 2020 12:10:16 -0800 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 12:10:15 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX151.amr.corp.intel.com ([169.254.7.99]) with mapi id 14.03.0439.000; Wed, 29 Jan 2020 12:10:15 -0800 From: "Michael D Kinney" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" Subject: Re: [PATCH v6 0/2] CryptoPkg/HashApiLib: Implement Unified Hash Calculation API Thread-Topic: [PATCH v6 0/2] CryptoPkg/HashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV1gVRMo3qASUng0qpuAl+3tncSKgB5WFw Date: Wed, 29 Jan 2020 20:10:15 +0000 Message-ID: References: <20200128180340.15136-1-amol.n.sukerkar@intel.com> In-Reply-To: <20200128180340.15136-1-amol.n.sukerkar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Amol, 1) Typo in CryptoPkg.dec. Should be Crypto Package, not Security package. [Guids] ## Security package token space guid. 2) CryptoPkg.dec/uni. I see the default value for PcdHashApiLibPolicy is 0x04. This is documented to be SHA256. The DEC/UNI file descriptions of this PCD should state that the default policy is SHA256. This makes it clear to platform developers that maintain DSC files what the default policy is. 3) CryptoPkg.dsc: The same HashApiLib instance is used for all module types so a single mapping can be moved to [LibraryClasses] section and the DSC file and removed from the [LibraryClass.common.] section= s. 4) The name of the HashApiLib instance should be "BaseHashApiLib" and the should be in the CryptoPkg/Library/BaseHashApiLib directory with files BashHashApiLib.inf, BaseHashApiLib.c, and BaseHashApiLib.uni. BASE_NAME in BaseHashApiLib.iunf should also be BaseHashApiLib. 5) In order to be consistent with other EDK II context typedefs, I recommen= d typedef VOID *HASH_API_CONTEXT; Also update APIs to use HashContext instead of *HashContext. 6) HashApiDuplicate() - The NewHashContext parameter should be type HASH_API_CONTEXT. 7) HashApiLib.inf - I think you can remove MdeModulePkg.dec from [Packages] Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Tuesday, January 28, 2020 10:04 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, > Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > > Subject: [PATCH v6 0/2] CryptoPkg/HashApiLib: Implement > Unified Hash Calculation API >=20 > Currently, the UEFI drivers using the SHA/SM3 hashing > algorithms use hard-coded > API to calculate the hash, for instance, sha_256(...), > etc. Since SHA384 and/or > SM3_256 are being increasingly adopted for robustness, > it becomes cumbersome to > modify each driver that calls into hash calculating API. >=20 > To better achieve this, we are proposing a Unified API, > which can be used by UEFI > drivers, that provides the drivers with flexibility to > use the desired hashing > algorithm based on the required robnustness. >=20 > Alternatively, the design document is also attached to > Bugzilla, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. >=20 > Sukerkar, Amol N (2): > CryptoPkg: Add CryptoPkg Token Space GUID > CryptoPkg/HashApiLib: Implement Unified Hash > Calculation API >=20 > CryptoPkg/Library/HashApiLib/HashApiLib.c | 333 > ++++++++++++++++++++ > CryptoPkg/CryptoPkg.dec | 27 +- > CryptoPkg/CryptoPkg.dsc | 7 +- > CryptoPkg/CryptoPkg.uni | 17 + > CryptoPkg/Include/Library/HashApiLib.h | 122 > +++++++ > CryptoPkg/Library/HashApiLib/HashApiLib.inf | 45 +++ > CryptoPkg/Library/HashApiLib/HashApiLib.uni | 17 + > 7 files changed, 566 insertions(+), 2 deletions(-) > create mode 100644 > CryptoPkg/Library/HashApiLib/HashApiLib.c > create mode 100644 > CryptoPkg/Include/Library/HashApiLib.h > create mode 100644 > CryptoPkg/Library/HashApiLib/HashApiLib.inf > create mode 100644 > CryptoPkg/Library/HashApiLib/HashApiLib.uni >=20 > -- > 2.16.2.windows.1