From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.129.1580489539055570459 for ; Fri, 31 Jan 2020 08:52:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2020 08:52:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,386,1574150400"; d="scan'208";a="218661437" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga007.jf.intel.com with ESMTP; 31 Jan 2020 08:52:04 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX107.amr.corp.intel.com ([169.254.1.15]) with mapi id 14.03.0439.000; Fri, 31 Jan 2020 08:52:04 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Kinney, Michael D" CC: "Zhang, Chao B" , "Wang, Jian J" , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy Thread-Topic: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy Thread-Index: AQHVzKAr/+ElsmeVKUm+2G2+2jSfcqgEKWCQgADf9oCAABUdgP//9Apg Date: Fri, 31 Jan 2020 16:52:04 +0000 Message-ID: References: <20200116190705.18816-1-lersek@redhat.com> <45017d12-10e1-8a9b-2997-c8fa42fc1049@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, I suspect the behavior you observed was due to the PR being opened, which triggers the CI actions immediately. Then you set the 'push' label, which=20 was not seen when the PR was opened. This required a second pass which you did by re-opening. There are 2 approaches a maintainer can take: 1) Open PR without 'push' label. Wait for CI checks to run and review status. If all pass, then set=20 the 'push' label and re-open. This option does cause 2 passes through the CI checks for a good patch series. 2) Open PR with the 'push' label set. If all checks pass, then it is merged. If any checks fail, then the maintainer can address and do a forced push to=20 their branch to retry. Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Laszlo Ersek > Sent: Friday, January 31, 2020 1:28 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Zhang, Chao B ; Wang, Jian > J ; Yao, Jiewen > > Subject: Re: [edk2-devel] [PATCH 00/11] > SecurityPkg/DxeImageVerificationHandler: fix retval for > "deny" policy >=20 > Hi Mike, >=20 > On 01/31/20 09:12, Laszlo Ersek wrote: >=20 > > So let me push this series as-is for TianoCore#2129, > with your R-b > > applied. >=20 > My pull request (with the "push" label set) seems to > have stalled. The > checks have passed (twice -- I closed and reopened the > PR once, to > re-trigger mergify), but the branch is not being > merged. >=20 > https://github.com/tianocore/edk2/pull/324 >=20 > Thanks > Laszlo >=20 >=20 >=20