From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: Sean <sean.brogan@microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues
Date: Sat, 1 Feb 2020 16:49:03 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9E84AD5@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <735.1580517191418120408@groups.io>
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
Sean,
I agree the hard coded paths are not good. This was a quick workaround to see if I could get the Azure Pipeline agents to function. It we continue this path, we would have to migrate those out to something like toolsdef.txt or other mechanism that is more flexible.
There is a fundamental assumption that all edk2 build environments support a host POSIX build. It would be better to update Azure Pipelines config to meet this assumption, and I can abandon this patch with the hard coded paths.
Do you have a suggestion for a patch to the Azure Pipelines YAML files to setup the VS host env?
Thanks,
Mike
From: sean.brogan via [] <sean.brogan=microsoft.com@[]>
Sent: Friday, January 31, 2020 4:33 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues
Mike,
The hardcoded vs paths are not a safe assumption.
I would rather see agreement of how the environment should be configured prior to calling edk2 build and if being capable of building host os specific binaries is the requirement then that should be clarified and the scripts can be updated. That way this type of stuff is contained within environment specific scripts rather than the edk2 build system.
thanks
Sean
[-- Attachment #2: Type: text/html, Size: 41296 bytes --]
next prev parent reply other threads:[~2020-02-01 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 2:37 [Patch] BaseTools/Build: Fix Structured PCD app host env issues Michael D Kinney
2020-01-31 8:27 ` Liming Gao
2020-01-31 16:42 ` Michael D Kinney
2020-02-01 0:33 ` [edk2-devel] " Sean
2020-02-01 16:49 ` Michael D Kinney [this message]
2020-02-03 2:19 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9E84AD5@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox