Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

["Michael D Kinney" <michael.d.kinney@intel.com>]

Hi Amol,

Thanks for the updates.  They all look great.

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Sukerkar, Amol N
> Sent: Monday, February 3, 2020 10:19 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Agrawal, Sachin
> <sachin.agrawal@intel.com>; Musti, Srinivas
> <srinivas.musti@intel.com>; Lakkimsetti, Subash
> <subash.lakkimsetti@intel.com>; Mathews, John
> <john.mathews@intel.com>
> Subject: [edk2-devel] [PATCH v9 0/2]
> CryptoPkg/BaseHashApiLib: Implement Unified Hash
> Calculation API
> 
> Currently, the UEFI drivers using the SHA/SM3 hashing
> algorithms use hard-coded
> API to calculate the hash, for instance, sha_256(...),
> etc. Since SHA384 and/or
> SM3_256 are being increasingly adopted for robustness,
> it becomes cumbersome to
> modify each driver that calls into hash calculating
> API.
> 
> To better achieve this, we are proposing a Unified API,
> which can be used by UEFI
> drivers, that provides the drivers with flexibility to
> use the desired hashing
> algorithm based on the required robnustness.
> 
> Alternatively, the design document is also attached to
> Bugzilla,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2151.
> 
> Amol N Sukerkar (2):
>   CryptoPkg: Add CryptoPkg Token Space GUID
>   CryptoPkg/BaseHashApiLib: Implement Unified Hash
> Calculation API
> 
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c   |
> 333 ++++++++++++++++++++
>  CryptoPkg/CryptoPkg.dec                             |
> 26 +-
>  CryptoPkg/CryptoPkg.dsc                             |
> 4 +-
>  CryptoPkg/CryptoPkg.uni                             |
> 18 +-
>  CryptoPkg/Include/Library/HashApiLib.h              |
> 122 +++++++
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf |
> 44 +++
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni |
> 17 +
>  7 files changed, 561 insertions(+), 3 deletions(-)
>  create mode 100644
> CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c
>  create mode 100644
> CryptoPkg/Include/Library/HashApiLib.h
>  create mode 100644
> CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
>  create mode 100644
> CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni
> 
> --
> 2.16.2.windows.1
> 
> 
>