From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.2578.1580754970583432377 for ; Mon, 03 Feb 2020 10:36:10 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 10:36:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="234786345" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga006.jf.intel.com with ESMTP; 03 Feb 2020 10:36:09 -0800 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 10:36:09 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX159.amr.corp.intel.com ([169.254.11.41]) with mapi id 14.03.0439.000; Mon, 3 Feb 2020 10:36:09 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Sukerkar, Amol N" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82Q Date: Mon, 3 Feb 2020 18:36:08 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: <20200203181850.17732-1-amol.n.sukerkar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Amol, Thanks for the updates. They all look great. Series Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Sukerkar, Amol N > Sent: Monday, February 3, 2020 10:19 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > > Subject: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > Currently, the UEFI drivers using the SHA/SM3 hashing > algorithms use hard-coded > API to calculate the hash, for instance, sha_256(...), > etc. Since SHA384 and/or > SM3_256 are being increasingly adopted for robustness, > it becomes cumbersome to > modify each driver that calls into hash calculating > API. >=20 > To better achieve this, we are proposing a Unified API, > which can be used by UEFI > drivers, that provides the drivers with flexibility to > use the desired hashing > algorithm based on the required robnustness. >=20 > Alternatively, the design document is also attached to > Bugzilla, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. >=20 > Amol N Sukerkar (2): > CryptoPkg: Add CryptoPkg Token Space GUID > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > 333 ++++++++++++++++++++ > CryptoPkg/CryptoPkg.dec | > 26 +- > CryptoPkg/CryptoPkg.dsc | > 4 +- > CryptoPkg/CryptoPkg.uni | > 18 +- > CryptoPkg/Include/Library/HashApiLib.h | > 122 +++++++ > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | > 44 +++ > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni | > 17 + > 7 files changed, 561 insertions(+), 3 deletions(-) > create mode 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > create mode 100644 > CryptoPkg/Include/Library/HashApiLib.h > create mode 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > create mode 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20