From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.5228.1580766578103405996 for ; Mon, 03 Feb 2020 13:49:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 13:49:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="263598700" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 13:49:37 -0800 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 13:49:36 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX161.amr.corp.intel.com ([169.254.4.2]) with mapi id 14.03.0439.000; Mon, 3 Feb 2020 13:49:36 -0800 From: "Michael D Kinney" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82QgAAFWpCAACy/gA== Date: Mon, 3 Feb 2020 21:49:36 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Amol, I prepared a branch an GitHub PR with this content. The EDK II CI checks found duplicate GUID issues: PROGRESS - --Running CryptoPkg: Guid Check Test NO-TARGET -- ERROR - Error Duplicate guid: DDCBCFBA-8EEB-488A-96D6-097831A6E50B (2) GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: HashLibBaseCryptoRouterP= ei FILE: /home/vsts/work/1/s/SecurityPkg/Library/HashLibBaseCryptoRouter/Ha= shLibBaseCryptoRouterPei.inf GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: BaseHashApiLib FILE: /ho= me/vsts/work/1/s/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf ERROR - Error Duplicate guid: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA (2) GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiSecurityPkgTokenSpac= eGuid FILE: /home/vsts/work/1/s/SecurityPkg/SecurityPkg.dec GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiCryptoPkgTokenSpaceG= uid FILE: /home/vsts/work/1/s/CryptoPkg/CryptoPkg.dec I generated new GUID value for the CryptoPkg Token Space GUID and a=20 new GUID value for BaseHashLib.inf and restarted the EDK II CI checks. Please let me know if you have any issues with the change I made: https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLib_V9 The GitHub PR is at: https://github.com/tianocore/edk2/pull/328 Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Monday, February 3, 2020 10:55 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > ; Sukerkar, Amol N > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > Thanks for the review, Mike! >=20 > ~ Amol >=20 > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Michael D Kinney > Sent: Monday, February 03, 2020 11:36 AM > To: devel@edk2.groups.io; Sukerkar, Amol N > ; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > > Subject: Re: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > Hi Amol, >=20 > Thanks for the updates. They all look great. >=20 > Series Reviewed-by: Michael D Kinney > >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of > > Sukerkar, Amol N > > Sent: Monday, February 3, 2020 10:19 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; > Yao, Jiewen > > ; Wang, Jian J > ; Agrawal, > > Sachin ; Musti, Srinivas > > ; Lakkimsetti, Subash > > ; Mathews, John > > > Subject: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Currently, the UEFI drivers using the SHA/SM3 hashing > algorithms use > > hard-coded API to calculate the hash, for instance, > sha_256(...), etc. > > Since SHA384 and/or > > SM3_256 are being increasingly adopted for > robustness, it becomes > > cumbersome to modify each driver that calls into hash > calculating API. > > > > To better achieve this, we are proposing a Unified > API, which can be > > used by UEFI drivers, that provides the drivers with > flexibility to > > use the desired hashing algorithm based on the > required robnustness. > > > > Alternatively, the design document is also attached > to Bugzilla, > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. > > > > Amol N Sukerkar (2): > > CryptoPkg: Add CryptoPkg Token Space GUID > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > | > > 333 ++++++++++++++++++++ > > CryptoPkg/CryptoPkg.dec > | > > 26 +- > > CryptoPkg/CryptoPkg.dsc > | > > 4 +- > > CryptoPkg/CryptoPkg.uni > | > > 18 +- > > CryptoPkg/Include/Library/HashApiLib.h > | > > 122 +++++++ > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > | > > 44 +++ > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > | > > 17 + > > 7 files changed, 561 insertions(+), 3 deletions(-) > create mode > > 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > create mode 100644 > > CryptoPkg/Include/Library/HashApiLib.h > > create mode 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > create mode 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > > > -- > > 2.16.2.windows.1 > > > > > > >=20 >=20 >=20 >=20