From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web09.6055.1580769494250247086 for ; Mon, 03 Feb 2020 14:38:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 14:19:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="224088692" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga008.jf.intel.com with ESMTP; 03 Feb 2020 14:19:17 -0800 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 14:19:17 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX151.amr.corp.intel.com ([169.254.7.99]) with mapi id 14.03.0439.000; Mon, 3 Feb 2020 14:19:17 -0800 From: "Michael D Kinney" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82QgAAFWpCAACy/gIAAB3QAgAADfuA= Date: Mon, 3 Feb 2020 22:19:16 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Amol, One additional issue was found by the Linux/GCC build. The lib class .h file was correct, but I missed that=20 the context parameter updates were not propagated to the BaseHashApiLib instance. So there were function=20 prototype mismatches between the class and the instance. I have corrected these and pushed the branch again to=20 re-run the EDK II CI checks. https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLib_V9 Please review and let me know if you have any issues. Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Monday, February 3, 2020 2:04 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > ; Sukerkar, Amol N > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > Hi Mike, >=20 > I have no issue with generating new GUIDs. >=20 > Thanks, > Amol >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, February 03, 2020 2:50 PM > To: Sukerkar, Amol N ; > devel@edk2.groups.io; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Musti, Srinivas > ; Lakkimsetti, Subash > ; Mathews, John > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API >=20 > Hi Amol, >=20 > I prepared a branch an GitHub PR with this content. >=20 > The EDK II CI checks found duplicate GUID issues: >=20 > PROGRESS - --Running CryptoPkg: Guid Check Test NO- > TARGET -- ERROR - Error Duplicate guid: DDCBCFBA-8EEB- > 488A-96D6-097831A6E50B (2) > GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: > HashLibBaseCryptoRouterPei FILE: > /home/vsts/work/1/s/SecurityPkg/Library/HashLibBaseCryp > toRouter/HashLibBaseCryptoRouterPei.inf > GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: > BaseHashApiLib FILE: > /home/vsts/work/1/s/CryptoPkg/Library/BaseHashApiLib/Ba > seHashApiLib.inf >=20 > ERROR - Error Duplicate guid: 0D3FB176-9569-4D51-A3EF- > 7D61C64FEABA (2) > GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: > gEfiSecurityPkgTokenSpaceGuid FILE: > /home/vsts/work/1/s/SecurityPkg/SecurityPkg.dec > GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: > gEfiCryptoPkgTokenSpaceGuid FILE: > /home/vsts/work/1/s/CryptoPkg/CryptoPkg.dec >=20 > I generated new GUID value for the CryptoPkg Token > Space GUID and a new GUID value for BaseHashLib.inf and > restarted the EDK II CI checks. >=20 > Please let me know if you have any issues with the > change I made: >=20 >=20 > https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLi > b_V9 >=20 > The GitHub PR is at: >=20 > https://github.com/tianocore/edk2/pull/328 >=20 > Thanks, >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Sukerkar, Amol N > > Sent: Monday, February 3, 2020 10:55 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Agrawal, Sachin > ; > > Musti, Srinivas ; > Lakkimsetti, Subash > > ; Mathews, John > > ; Sukerkar, Amol N > > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Thanks for the review, Mike! > > > > ~ Amol > > > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of Michael > > D Kinney > > Sent: Monday, February 03, 2020 11:36 AM > > To: devel@edk2.groups.io; Sukerkar, Amol N > > ; Kinney, Michael D > > > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Agrawal, Sachin > ; > > Musti, Srinivas ; > Lakkimsetti, Subash > > ; Mathews, John > > > Subject: Re: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Hi Amol, > > > > Thanks for the updates. They all look great. > > > > Series Reviewed-by: Michael D Kinney > > > > > > Mike > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io > On > > Behalf Of > > > Sukerkar, Amol N > > > Sent: Monday, February 3, 2020 10:19 AM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D ; > > Yao, Jiewen > > > ; Wang, Jian J > > ; Agrawal, > > > Sachin ; Musti, Srinivas > > > ; Lakkimsetti, Subash > > > ; Mathews, John > > > > > Subject: [edk2-devel] [PATCH v9 0/2] > > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > > Calculation API > > > > > > Currently, the UEFI drivers using the SHA/SM3 > hashing > > algorithms use > > > hard-coded API to calculate the hash, for instance, > > sha_256(...), etc. > > > Since SHA384 and/or > > > SM3_256 are being increasingly adopted for > > robustness, it becomes > > > cumbersome to modify each driver that calls into > hash > > calculating API. > > > > > > To better achieve this, we are proposing a Unified > > API, which can be > > > used by UEFI drivers, that provides the drivers > with > > flexibility to > > > use the desired hashing algorithm based on the > > required robnustness. > > > > > > Alternatively, the design document is also attached > > to Bugzilla, > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. > > > > > > Amol N Sukerkar (2): > > > CryptoPkg: Add CryptoPkg Token Space GUID > > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > > Calculation API > > > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > | > > > 333 ++++++++++++++++++++ > > > CryptoPkg/CryptoPkg.dec > > | > > > 26 +- > > > CryptoPkg/CryptoPkg.dsc > > | > > > 4 +- > > > CryptoPkg/CryptoPkg.uni > > | > > > 18 +- > > > CryptoPkg/Include/Library/HashApiLib.h > > | > > > 122 +++++++ > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > | > > > 44 +++ > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > | > > > 17 + > > > 7 files changed, 561 insertions(+), 3 deletions(-) > > create mode > > > 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > > create mode 100644 > > > CryptoPkg/Include/Library/HashApiLib.h > > > create mode 100644 > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > > create mode 100644 > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > > > > > -- > > > 2.16.2.windows.1 > > > > > > > > > > > > > > >=20 > > >=20 >=20