From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.588.1580919379142697222 for ; Wed, 05 Feb 2020 08:16:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 08:16:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,406,1574150400"; d="scan'208";a="231757800" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 05 Feb 2020 08:16:18 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 08:16:18 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.57]) by ORSMSX157.amr.corp.intel.com ([169.254.9.76]) with mapi id 14.03.0439.000; Wed, 5 Feb 2020 08:16:17 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Kinney, Michael D" CC: "Zhang, Chao B" , "Wang, Jian J" , "Yao, Jiewen" Subject: Re: setting the push label at once, when opening a PR [was: SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy] Thread-Topic: setting the push label at once, when opening a PR [was: SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy] Thread-Index: AQHV3CSEK1T554lvSEmWIFIOc1RGwqgMxU1w Date: Wed, 5 Feb 2020 16:16:17 +0000 Message-ID: References: <20200116190705.18816-1-lersek@redhat.com> <45017d12-10e1-8a9b-2997-c8fa42fc1049@redhat.com> <245e69b7-be55-4d38-9a75-dbc3fd227e77@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, If I follow this link, I see the expected screen with the ability to set a = label: https://github.com/lersek/edk2/pull/new/smram_at_default_smbase_bz_1512_wav= e_1_v2_pull If I type in the following URL from your screen shot, I also get the same s= creen with the ability to set a label: https://github.com/tianocore/edk2/compare/master...lersek:smram_at_default_= smbase_bz_1512_wave_1_v2_pull?expand=3D1 It also looks like you are logged into GitHub, so that does not appear to b= e the issue. I also verified you are a member of EDK II Maintainers, so that does not ap= pear to be the issue. Can you try both of the links above again? Mike > -----Original Message----- > From: Laszlo Ersek > Sent: Wednesday, February 5, 2020 5:02 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Zhang, Chao B ; Wang, Jian > J ; Yao, Jiewen > > Subject: setting the push label at once, when opening a > PR [was: SecurityPkg/DxeImageVerificationHandler: fix > retval for "deny" policy] >=20 > Hi Mike, >=20 > On 01/31/20 21:19, Laszlo Ersek wrote: > > On 01/31/20 18:28, Kinney, Michael D wrote: > >> Hi Laszlo, > >> > >> It can be done with the WebUI. There is a picture on > >> this page that shows setting the 'push' label before > >> selecting 'Create Pull Request' > >> > >> > https://github.com/tianocore/tianocore.github.io/wiki/E > DK-II-Development-Process > > > > Aha, found it: > > > > > https://raw.githubusercontent.com/wiki/tianocore/tianoc > ore.github.io/images/CreateGitHubPullRequest2.png > > > > Many thanks, I'll use it in the future! >=20 > the label in question is not there for me. >=20 > I've just pushed a new topic branch, for the purposes > of PR / merging. After running the git-push command > locally, I opened the URL in my browser that > github.com's remote git daemon printed to my terminal, > in response to my git-push command: >=20 > > Enumerating objects: 103, done. > > Counting objects: 100% (103/103), done. > > Delta compression using up to 4 threads > > Compressing objects: 100% (76/76), done. > > Writing objects: 100% (76/76), 15.62 KiB | 3.91 > MiB/s, done. > > Total 76 (delta 64), reused 0 (delta 0) > > remote: Resolving deltas: 100% (64/64), completed > with 24 local objects. > > remote: > > remote: Create a pull request for > 'smram_at_default_smbase_bz_1512_wave_1_v2_pull' on > GitHub by visiting: > > remote: > https://github.com/lersek/edk2/pull/new/smram_at_defaul > t_smbase_bz_1512_wave_1_v2_pull > > remote: > > To github.com:lersek/edk2.git > > * [new branch] > smram_at_default_smbase_bz_1512_wave_1_v2_pull -> > smram_at_default_smbase_bz_1512_wave_1_v2_pull >=20 > Please see the attachment (screenshot) of what I found > under that link. (I even used the browser's "in-page > search" function, to locate the word "label"; it was > not there.) >=20 > Thanks! > Laszlo