From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mx.groups.io with SMTP id smtpd.web09.703.1581719383621960153
 for <devel@edk2.groups.io>;
 Fri, 14 Feb 2020 14:29:43 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.d.kinney@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 14:29:42 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,442,1574150400"; 
   d="scan'208";a="228618087"
Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5])
  by fmsmga008.fm.intel.com with ESMTP; 14 Feb 2020 14:29:42 -0800
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.183]) by
 ORSMSX107.amr.corp.intel.com ([169.254.1.106]) with mapi id 14.03.0439.000;
 Fri, 14 Feb 2020 14:29:41 -0800
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Sukerkar, Amol N" <amol.n.sukerkar@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Yao, Jiewen" <jiewen.yao@intel.com>, "Wang, Jian J"
	<jian.j.wang@intel.com>, "Agrawal, Sachin" <sachin.agrawal@intel.com>, "Gao,
 Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to FixedAtBuild
Thread-Topic: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Change
 PcdHashApiLibPolicy type to FixedAtBuild
Thread-Index: AQHV42FmhlokVzdEjE6CoOSabmLdpqgbRXVw
Date: Fri, 14 Feb 2020 22:29:42 +0000
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9EBA575@ORSMSX113.amr.corp.intel.com>
References: <20200214180545.5872-1-amol.n.sukerkar@intel.com>
 <20200214180545.5872-3-amol.n.sukerkar@intel.com>
In-Reply-To: <20200214180545.5872-3-amol.n.sukerkar@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.140]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Amol,

Comments included below.

Mike

> -----Original Message-----
> From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Sent: Friday, February 14, 2020 10:06 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Agrawal, Sachin
> <sachin.agrawal@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib:
> Change PcdHashApiLibPolicy type to FixedAtBuild
>=20
> Ref:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511
>=20
> This commit changes the PCD PcdHashApiLibPolicy to the
> type
> PcdsFixedAtBuild so as to be able to optimize away the
> unused hashing
> algorithms in HashApiLib instance used by a driver.
>=20
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Amol N Sukerkar
> <amol.n.sukerkar@intel.com>
> ---
>=20
> Notes:
>     v2
>     - Fixed closed parantheses in the commit message
>=20
>  CryptoPkg/CryptoPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/CryptoPkg/CryptoPkg.dec
> b/CryptoPkg/CryptoPkg.dec
> index f185bcc82515..c23af7b87d25 100644
> --- a/CryptoPkg/CryptoPkg.dec
> +++ b/CryptoPkg/CryptoPkg.dec
> @@ -69,7 +69,7 @@ [PcdsFixedAtBuild]
>        Pcd/PcdCryptoServiceFamilyEnable.h
>    }
>=20
> -[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
> PcdsDynamicEx]
> +[PcdsFixedAtBuild]

This line can be removed.  The PCD above is already in a
[PcdsFixedAtBuild] section.

>    ## This PCD indicates the HASH algorithm to
> calculate hash of data
>    #  Based on the value set, the required algorithm is
> chosen to calculate
>    #  the hash of data.<BR>
> --
> 2.16.2.windows.1