From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1878.1581725053137019969 for ; Fri, 14 Feb 2020 16:04:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 16:04:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,442,1574150400"; d="scan'208";a="228636236" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga008.fm.intel.com with ESMTP; 14 Feb 2020 16:04:12 -0800 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 14 Feb 2020 16:04:11 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.183]) by ORSMSX159.amr.corp.intel.com ([169.254.11.53]) with mapi id 14.03.0439.000; Fri, 14 Feb 2020 16:04:11 -0800 From: "Michael D Kinney" To: "devel@edk2.groups.io" , "Sukerkar, Amol N" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Topic: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Index: AQHV441vbO4uVRrGh0WnWNfAkYVkNqgbXtlw Date: Sat, 15 Feb 2020 00:04:11 +0000 Message-ID: References: <20200214232100.11088-1-amol.n.sukerkar@intel.com> In-Reply-To: <20200214232100.11088-1-amol.n.sukerkar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Amol, Thanks for the quick update. I see you changed the PCD to type UINT16. I think this was based on Jiewen feedback to use a set of TPM specific=20 algorithms defines that were UINT16. However, the HASH define values being used are 32-bits and everywhere else that those defines values are used, they are also 32-bits. I recommend we keep the type UINT32, and use 8 digit hex values in all references to the values and valid value checks. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On > Behalf Of Sukerkar, Amol N > Sent: Friday, February 14, 2020 3:21 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Gao, Liming > > Subject: [edk2-devel] [PATCH v3 0/2] Enhancement and > Fixes to BaseHashApiLib >=20 > This patch implements the fixes and enhancement to > BaseHashApiLib in > the following manner: > - Remove reference to MD4 and MD5 hashing algorithms as > they are > deprecated; > - Align the enumeration for hashing algorithmswith the > one used in > TPM 2.0 implementation defined in > IndustryStandard/Tpm20.h; > - Change the type of PcdHashApiLibPolicy to > PcdsFixedAtBuild to > optimize away the unused hashing algorithms for a > particular > instance of HashApiLib. >=20 > More information can be found at Bugzilla ticket, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511. >=20 > Amol N Sukerkar (2): > CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with > TPM 2.0 > Implementation > CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy > type to > FixedAtBuild >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > 121 ++++++-------------- > CryptoPkg/CryptoPkg.dec | > 18 ++- > CryptoPkg/CryptoPkg.uni | > 12 +- > CryptoPkg/Include/Library/HashApiLib.h | > 16 +-- > 4 files changed, 52 insertions(+), 115 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20