From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.2074.1581725591540293246 for ; Fri, 14 Feb 2020 16:13:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.d.kinney@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 16:13:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,442,1574150400"; d="scan'208";a="227529204" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga007.fm.intel.com with ESMTP; 14 Feb 2020 16:13:11 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.183]) by ORSMSX107.amr.corp.intel.com ([169.254.1.106]) with mapi id 14.03.0439.000; Fri, 14 Feb 2020 16:13:10 -0800 From: "Michael D Kinney" To: "Sukerkar, Amol N" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Topic: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Index: AQHV441vbO4uVRrGh0WnWNfAkYVkNqgbXtlwgAABYxCAAAHXEA== Date: Sat, 15 Feb 2020 00:13:10 +0000 Message-ID: References: <20200214232100.11088-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. That is correct. Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Friday, February 14, 2020 4:12 PM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Gao, Liming > ; Sukerkar, Amol N > > Subject: RE: [edk2-devel] [PATCH v3 0/2] Enhancement > and Fixes to BaseHashApiLib >=20 > Hi Mike, >=20 > Although the values were listed in 8-digit hex format, > the PCD, PcdHashApiLibPolicy itself was of type UINT8 > earlier that was changed to UINT16. I agree changing > the type to UINT32 will align with all the other PCDs > implementing TCG spec (and using Tpm20.h defines). Can > you confirm my understanding is accurate? >=20 > Thanks, > Amol >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, February 14, 2020 5:04 PM > To: devel@edk2.groups.io; Sukerkar, Amol N > ; Kinney, Michael D > > Cc: Yao, Jiewen ; Wang, Jian J > ; Agrawal, Sachin > ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH v3 0/2] Enhancement > and Fixes to BaseHashApiLib >=20 > Amol, >=20 > Thanks for the quick update. >=20 > I see you changed the PCD to type UINT16. I think this > was based on Jiewen feedback to use a set of TPM > specific algorithms defines that were UINT16. >=20 > However, the HASH define values being used are 32-bits > and everywhere else that those defines values are used, > they are also 32-bits. >=20 > I recommend we keep the type UINT32, and use 8 digit > hex values in all references to the values and valid > value checks. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of > > Sukerkar, Amol N > > Sent: Friday, February 14, 2020 3:21 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; > Yao, Jiewen > > ; Wang, Jian J > ; Agrawal, > > Sachin ; Gao, Liming > > > Subject: [edk2-devel] [PATCH v3 0/2] Enhancement and > Fixes to > > BaseHashApiLib > > > > This patch implements the fixes and enhancement to > BaseHashApiLib in > > the following manner: > > - Remove reference to MD4 and MD5 hashing algorithms > as they are > > deprecated; > > - Align the enumeration for hashing algorithmswith > the one used in > > TPM 2.0 implementation defined in > > IndustryStandard/Tpm20.h; > > - Change the type of PcdHashApiLibPolicy to > PcdsFixedAtBuild to > > optimize away the unused hashing algorithms for a > particular > > instance of HashApiLib. > > > > More information can be found at Bugzilla ticket, > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511. > > > > Amol N Sukerkar (2): > > CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with > TPM 2.0 > > Implementation > > CryptoPkg/BaseHashApiLib: Change > PcdHashApiLibPolicy type to > > FixedAtBuild > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > > 121 ++++++-------------- > > CryptoPkg/CryptoPkg.dec | > > 18 ++- > > CryptoPkg/CryptoPkg.uni | > > 12 +- > > CryptoPkg/Include/Library/HashApiLib.h | > > 16 +-- > > 4 files changed, 52 insertions(+), 115 deletions(-) > > > > -- > > 2.16.2.windows.1 > > > > > >=20 >=20 >=20