From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by mx.groups.io with SMTP id smtpd.web09.3660.1581797870318981274
 for <devel@edk2.groups.io>;
 Sat, 15 Feb 2020 12:17:50 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.d.kinney@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2020 12:17:49 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,445,1574150400"; 
   d="scan'208";a="433377105"
Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132])
  by fmsmga005.fm.intel.com with ESMTP; 15 Feb 2020 12:17:49 -0800
Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by
 ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sat, 15 Feb 2020 12:17:48 -0800
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.183]) by
 ORSMSX153.amr.corp.intel.com ([169.254.12.187]) with mapi id 14.03.0439.000;
 Sat, 15 Feb 2020 12:17:48 -0800
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "Sukerkar, Amol N" <amol.n.sukerkar@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, "Kinney, Michael D" <michael.d.kinney@intel.com>
CC: "Yao, Jiewen" <jiewen.yao@intel.com>, "Wang, Jian J"
	<jian.j.wang@intel.com>, "Agrawal, Sachin" <sachin.agrawal@intel.com>, "Gao,
 Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib
Thread-Topic: [PATCH v6 0/2] Enhancement and Fixes to BaseHashApiLib
Thread-Index: AQHV5DlDqkURGO/0fE67EMt8520WoagcsWFQ
Date: Sat, 15 Feb 2020 20:17:48 +0000
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9EBA941@ORSMSX113.amr.corp.intel.com>
References: <20200215195103.9848-1-amol.n.sukerkar@intel.com>
In-Reply-To: <20200215195103.9848-1-amol.n.sukerkar@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
MIME-Version: 1.0
Return-Path: michael.d.kinney@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike


> -----Original Message-----
> From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Sent: Saturday, February 15, 2020 11:51 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Agrawal, Sachin
> <sachin.agrawal@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH v6 0/2] Enhancement and Fixes to
> BaseHashApiLib
>=20
> This patch implements the fixes and enhancement to
> BaseHashApiLib in
> the following manner:
> - Remove reference to MD4 and MD5 hashing algorithms as
> they are
>   deprecated;
> - Align the enumeration for hashing algorithmswith the
> one used in
>   TPM 2.0 implementation defined in
> IndustryStandard/Tpm20.h;
> - Change the type of PcdHashApiLibPolicy to
> PcdsFixedAtBuild to
>   optimize away the unused hashing algorithms for a
> particular
>   instance of HashApiLib.
>=20
> More information can be found at Bugzilla ticket,
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511.
>=20
> Amol N Sukerkar (2):
>   CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with
> TPM 2.0
>     Implementation
>   CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy
> type to
>     FixedAtBuild
>=20
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c |
> 121 ++++++--------------
>  CryptoPkg/CryptoPkg.dec                           |
> 17 ++-
>  CryptoPkg/CryptoPkg.uni                           |
> 12 +-
>  CryptoPkg/Include/Library/HashApiLib.h            |
> 16 +--
>  4 files changed, 51 insertions(+), 115 deletions(-)
>=20
> --
> 2.16.2.windows.1