From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Adding Bhyve support into upstream EDK2
Date: Tue, 10 Mar 2020 19:23:18 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9ECAA50@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <29466.1583867434210258945@groups.io>
[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]
Sean,
This is the reason that OvmfPkg was kept in the edk2 repo so only a single repo is required for local dev testing and CI testing. Same reason for the EmulatorPkg.
The current rule for the edk2 repo is common firmware packages and virtual/emulated platforms.
The fact that there has not been bandwidth to implement the CI testing for OvmfPkg or EmulatorPkg is not a reasonable reason to remove them.
Mike
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean via Groups.Io
Sent: Tuesday, March 10, 2020 12:11 PM
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; devel@edk2.groups.io
Subject: Re: [edk2-devel] Adding Bhyve support into upstream EDK2
On Tue, Mar 10, 2020 at 10:54 AM, Ard Biesheuvel wrote:
This means we can reasonably require any contributor not to regress on
those platforms, given how they have full access to it, and this is
actually where i would like us to take the next step when it comes to
ci automation, i.e., automatically flag PRs that break the boot on a
selected set of qemu based configs.
I appreciate the viewpoint but I don't think edk2 has "required" this yet and I would push back on that if it was brought up for community discussion. As you know I believe contributing to edk2 is much too hard already, and filled with custom edk2 workflows, and this one would only make it more of a burden to contribute.
I do however agree that if this is important to the edk2 community, systems/automation should be setup to run this type of thing. If that happens, i don't think it is much harder to do it for multi-repo than single repo and if done right for multi-repo then other platforms can opt in as well and the efforts to build this infrastructure will scale well beyond a single virtual platform.
Thanks
Sean
[-- Attachment #2: Type: text/html, Size: 42114 bytes --]
next prev parent reply other threads:[~2020-03-10 19:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:09 Adding Bhyve support into upstream EDK2 Rebecca Cran
2020-03-06 19:54 ` Laszlo Ersek
2020-03-06 20:04 ` [edk2-devel] " Laszlo Ersek
2020-03-07 1:29 ` Yao, Jiewen
2020-03-24 1:34 ` Rebecca Cran
2020-03-25 0:04 ` Laszlo Ersek
2020-03-25 18:18 ` [EXTERNAL] " Bret Barkelew
2020-03-27 12:56 ` Laszlo Ersek
2020-03-25 18:50 ` Rebecca Cran
[not found] ` <15F9E16A0219E7B7.19404@groups.io>
2020-03-07 1:43 ` Yao, Jiewen
2020-03-07 7:39 ` Laszlo Ersek
2020-03-07 7:52 ` Ard Biesheuvel
2020-03-08 2:40 ` Rebecca Cran
2020-03-09 6:08 ` Sean
2020-03-09 22:54 ` Laszlo Ersek
2020-03-09 23:17 ` Laszlo Ersek
2020-03-10 1:50 ` Sean
2020-03-10 9:05 ` Laszlo Ersek
2020-03-10 17:25 ` Sean
2020-03-10 17:54 ` Ard Biesheuvel
2020-03-10 19:10 ` Sean
2020-03-10 19:23 ` Michael D Kinney [this message]
2020-03-10 19:44 ` Sean
2020-03-10 20:04 ` Rebecca Cran
2020-03-11 0:05 ` Laszlo Ersek
2020-03-11 0:30 ` Sean
2020-03-11 3:21 ` Liming Gao
2020-03-10 23:34 ` Laszlo Ersek
2020-03-11 0:43 ` Leif Lindholm
2020-03-07 7:53 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9ECAA50@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox