public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael D Kinney" <michael.d.kinney@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] github PRs keep breaking for me
Date: Thu, 12 Mar 2020 21:57:09 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B9ECCA67@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <f3139a13-cca4-1458-e306-57e32e603af2@redhat.com>

Laszlo,

I understand your frustration.  Let's work on resolving 
these issues.

What browser are you using?  I would like the reproduce 
that issue and report to GitHub.  Do you a screen shot
where the labels button is not visibe?

Did you use the same branch name or a new branch name with
the same set of commits?  When I do a 2nd PR for the same
content, I use a new branch name.

The hub command is very flexible.  What commands did you try?

I want to root cause this issue.  I suspect it is more related
to Mergify than GitHub or Azure Pipelines.  There is a state 
machine that is watching statuses and the sequence of actions
you are using must be going into a state I did not test.
Are you able to provide the sequences of steps that got the
PR into a bad state and the approximate time between steps?

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Laszlo Ersek
> Sent: Thursday, March 12, 2020 2:06 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Sean
> Brogan <sean.brogan@microsoft.com>
> Subject: [edk2-devel] github PRs keep breaking for me
> 
> Hi Mike,
> 
> (1) github stopped supporting my browser. I can no
> longer apply the push
> label using my current browser. The "hub" cmdline
> utility does not seem
> to support adding just a label to an existing PR.
> 
> (2) github closed my PR as a personal build (due to
> lack of the "push"
> label), and now it even denies me the option to reopen
> the pull request.
> I deleted and re-pushed the (identical) branch, which
> github noticed in
> the PR, but it still wouldn't re-launch the CI build,
> or honor the
> "push" label.
> 
> CI is good, but github+mergify have turned the merging
> of valid patch
> series from a 3-second git-push command into repeated
> half-hour
> nightmares. Sorry for the strong words, I'm livid.
> 
> Laszlo
> 
> 
> 


  reply	other threads:[~2020-03-12 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 21:06 github PRs keep breaking for me Laszlo Ersek
2020-03-12 21:57 ` Michael D Kinney [this message]
2020-03-13 17:27   ` [edk2-devel] " Laszlo Ersek
2020-03-13 18:21     ` Rebecca Cran
2020-06-09 21:37   ` Laszlo Ersek
2020-06-09 21:51     ` Laszlo Ersek
2020-06-09 21:55       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B9ECCA67@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox