From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.17610.1584544515498056059 for ; Wed, 18 Mar 2020 08:15:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: michael.d.kinney@intel.com) IronPort-SDR: DPgbQIDQAVZZNfHQN+hknYDJ46XAY0eW+FeBuKrscZFcqocoeEapUKjeP1pMBnsaTDbWpHLD85 XKCFCbkbF+Mw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 08:15:14 -0700 IronPort-SDR: Wt5SgEAIVZwiy24JwK6jx16ecY+aYm0DlujUPia0gLxkFsYkKF3/r6YBzmXCHJ3H9/yy2j4CLS EqKQbyxHFDjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,568,1574150400"; d="scan'208";a="444197856" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga005.fm.intel.com with ESMTP; 18 Mar 2020 08:15:14 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Mar 2020 08:15:13 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.188]) by ORSMSX123.amr.corp.intel.com ([169.254.1.39]) with mapi id 14.03.0439.000; Wed, 18 Mar 2020 08:15:13 -0700 From: "Michael D Kinney" To: "Xu, Wei6" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: Kun Qin , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Topic: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Index: AQHV/Ow5vT2yNmSICkaUN57gAzHE8qhOdhfw Date: Wed, 18 Mar 2020 15:15:12 +0000 Message-ID: References: <20200318061227.12480-1-wei6.xu@intel.com> In-Reply-To: <20200318061227.12480-1-wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UmV2aWV3ZWQtYnk6IE1pY2hhZWwgRCBLaW5uZXkgPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29t Pg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFh1LCBXZWk2IDx3ZWk2 Lnh1QGludGVsLmNvbT4NCj4gU2VudDogVHVlc2RheSwgTWFyY2ggMTcsIDIwMjAgMTE6MTIgUE0N Cj4gVG86IGRldmVsQGVkazIuZ3JvdXBzLmlvDQo+IENjOiBLdW4gUWluIDxrdXFpbkBtaWNyb3Nv ZnQuY29tPjsgS2lubmV5LCBNaWNoYWVsIEQNCj4gPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29t PjsgR2FvLCBMaW1pbmcNCj4gPGxpbWluZy5nYW9AaW50ZWwuY29tPg0KPiBTdWJqZWN0OiBbZWRr Mi1kZXZlbF0gW1BBVENIXSBGbXBEZXZpY2VQa2cvRm1wRHhlOiBGaXgNCj4gdW5pbml0aWFsaXpl ZCBwb2ludGVyIGRlcmVmZXJlbmNlDQo+IA0KPiBGcm9tOiBLdW4gUWluIDxrdXFpbkBtaWNyb3Nv ZnQuY29tPg0KPiANCj4gUkVGOg0KPiBodHRwczovL2J1Z3ppbGxhLnRpYW5vY29yZS5vcmcvc2hv d19idWcuY2dpP2lkPTI2MDINCj4gDQo+IFplcm8gdGhlIGFsbG9jYXRlZCBidWZmZXIgaW4gY2Fz ZSBHZXRJbWFnZUluZm8NCj4gYGNvbnRpbnVlYCBpbiB0aGUgbWlkZGxlIG9mDQo+IGEgbG9vcC4g VGhpcyB3aWxsIGNhdXNlIHVuZXhwZWN0ZWQgR2V0SW1hZ2VJbmZvIGZhaWx1cmUNCj4gbm90IGNs ZWFyaW5nIHRoZQ0KPiBjb3JyZXNwb25kaW5nIGVudHJ5IGFuZCBsZWFkIHRvIEdQIGZhdWx0cyB3 aGVuDQo+IGRlcmVmZXJlbmNpbmcgdGhpcyBlbnRyeS4NCj4gDQo+IENjOiBNaWNoYWVsIEQgS2lu bmV5IDxtaWNoYWVsLmQua2lubmV5QGludGVsLmNvbT4NCj4gQ2M6IExpbWluZyBHYW8gPGxpbWlu Zy5nYW9AaW50ZWwuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBXZWk2IFh1IDx3ZWk2Lnh1QGludGVs LmNvbT4NCj4gLS0tDQo+ICBGbXBEZXZpY2VQa2cvRm1wRHhlL0RlcGVuZGVuY3kuYyB8IDIgKy0N Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4g ZGlmZiAtLWdpdCBhL0ZtcERldmljZVBrZy9GbXBEeGUvRGVwZW5kZW5jeS5jDQo+IGIvRm1wRGV2 aWNlUGtnL0ZtcER4ZS9EZXBlbmRlbmN5LmMNCj4gaW5kZXggOGY5N2M0MjkxNi4uNjVjMjM5ODlj NiAxMDA2NDQNCj4gLS0tIGEvRm1wRGV2aWNlUGtnL0ZtcER4ZS9EZXBlbmRlbmN5LmMNCj4gKysr IGIvRm1wRGV2aWNlUGtnL0ZtcER4ZS9EZXBlbmRlbmN5LmMNCj4gQEAgLTU1MCwxMSArNTUwLDEx IEBAIEV2YWx1YXRlSW1hZ2VEZXBlbmRlbmNpZXMgKA0KPiAgICAgICAgICAgICAgICAgICk7DQo+ ICAgIGlmIChFRklfRVJST1IgKFN0YXR1cykpIHsNCj4gICAgICByZXR1cm4gRUZJX0FCT1JURUQ7 DQo+ICAgIH0NCj4gDQo+IC0gIG1GbXBJbWFnZUluZm9CdWYgPSBBbGxvY2F0ZVBvb2wNCj4gKHNp emVvZihFRklfRklSTVdBUkVfSU1BR0VfREVTQ1JJUFRPUiAqKSAqDQo+IG1OdW1iZXJPZkZtcElu c3RhbmNlKTsNCj4gKyAgbUZtcEltYWdlSW5mb0J1ZiA9IEFsbG9jYXRlWmVyb1Bvb2wNCj4gKHNp emVvZihFRklfRklSTVdBUkVfSU1BR0VfREVTQ1JJUFRPUiAqKSAqDQo+IG1OdW1iZXJPZkZtcElu c3RhbmNlKTsNCj4gICAgaWYgKG1GbXBJbWFnZUluZm9CdWYgPT0gTlVMTCkgew0KPiAgICAgIHJl dHVybiBFRklfT1VUX09GX1JFU09VUkNFUzsNCj4gICAgfQ0KPiANCj4gICAgZm9yIChJbmRleCA9 IDA7IEluZGV4IDwgbU51bWJlck9mRm1wSW5zdGFuY2U7IEluZGV4DQo+ICsrKSB7DQo+IC0tDQo+ IDIuMTYuMi53aW5kb3dzLjENCg0K