From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.56282.1584979542577145683 for ; Mon, 23 Mar 2020 09:05:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.d.kinney@intel.com) IronPort-SDR: 7AOOIPB6D4U9NIZ+JY10rXf45u1Ix26z6PVgt3ij95OLCGBnO2hxZiKWaAW3wdvT4e/Gvgq7bH tffV9jDGe7/A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 09:05:40 -0700 IronPort-SDR: PLXg0O9vp++t/JKBC5Oxq0GoetF5NiwH15zvRDFb+s8i6gYv07MtkqdVAahkLHgH6pFe6fKxyy XTEgcSlaG3dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,297,1580803200"; d="scan'208";a="447438708" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga006.fm.intel.com with ESMTP; 23 Mar 2020 09:05:40 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 09:05:39 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.188]) by ORSMSX161.amr.corp.intel.com ([169.254.4.226]) with mapi id 14.03.0439.000; Mon, 23 Mar 2020 09:05:39 -0700 From: "Michael D Kinney" To: "Jiang, Guomin" , "devel@edk2.groups.io" , "Xu, Wei6" , Sean Brogan , "Kinney, Michael D" CC: Kun Qin , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Topic: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Thread-Index: AQHV/Ow5vT2yNmSICkaUN57gAzHE8qhOdhfwgAfMvoCAABzGwA== Date: Mon, 23 Mar 2020 16:05:39 +0000 Message-ID: References: <20200318061227.12480-1-wei6.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.d.kinney@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 VGhlIEJaIHJlcG9ydCBpbmRpY2F0ZXMgdGhhdCBhbiBpbnZhbGlkIHBvaW50IGFjY2Vzcw0Kd2Fz IG9ic2VydmVkLiAgUGVyaGFwcyBTZWFuIGNhbiBhZGQgdGhlIGRldGFpbHMgaW4gdGhlIEJaDQpm b3Igd2hpY2ggbGluZSBvZiBjb2RlIGdlbmVyYXRlZCBpbiBpbnZhbGlkIGFjY2Vzcy4NCg0KaHR0 cHM6Ly9idWd6aWxsYS50aWFub2NvcmUub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAyDQoNCk1pa2UN Cg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKaWFuZywgR3VvbWluIDxn dW9taW4uamlhbmdAaW50ZWwuY29tPg0KPiBTZW50OiBNb25kYXksIE1hcmNoIDIzLCAyMDIwIDEy OjIxIEFNDQo+IFRvOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbzsgS2lubmV5LCBNaWNoYWVsIEQNCj4g PG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPjsgWHUsIFdlaTYNCj4gPHdlaTYueHVAaW50ZWwu Y29tPg0KPiBDYzogS3VuIFFpbiA8a3VxaW5AbWljcm9zb2Z0LmNvbT47IEdhbywgTGltaW5nDQo+ IDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4gU3ViamVjdDogUkU6IFtlZGsyLWRldmVsXSBbUEFU Q0hdIEZtcERldmljZVBrZy9GbXBEeGU6DQo+IEZpeCB1bmluaXRpYWxpemVkIHBvaW50ZXIgZGVy ZWZlcmVuY2UNCj4gDQo+IEhpIFh1d2VpLCBRaW5LdW4sDQo+IA0KPiBIYXZlIHlvdSBpbmRlZWQg ZW5jb3VudGVyIHRoaXMgaXNzdWUgb3IganVzdCB0aGluayBpdA0KPiBpcyBwb3RlbnRpYWwgaXNz dWUuDQo+IA0KPiBJIHRoaW5rICBiZWxvdyBjb2RlIHdpbGwgYWx3YXlzIGluaXRpYWxpemUgdGhl DQo+IG1GbXBJbWFnZUluZm9CdWZbXSBhbmQgbWFrZSBzdXJlIGl0IGlzIHZhbGlkLg0KPiBMaW5l IDU4NSAtIG1GbXBJbWFnZUluZm9CdWZbSW5kZXhdID0gQWxsb2NhdGVaZXJvUG9vbA0KPiAoSW1h Z2VJbmZvU2l6ZSk7DQo+IA0KPiBJZiB0aGUgc2Vjb25kIEdldEltYWdlSW5mbygpIGlzIHJ1bm5l ZCwgSSB0aGluayBpdCB3aWxsDQo+IGFsd2F5cyBoYXZlIGNvcnJlY3QgbWZtcEltYWdlSW5mb0J1 ZltdIGFkZHJlc3MuDQo+IA0KPiBPZiBjb3Vyc2UsIGl0IGlzIG9rIHRvIHVzZSBBbGxvY2F0ZVpl cm9Qb29sIHRvIGVuc3VyZQ0KPiB6ZXJvIGJ1ZmZlciBpcyBhbGxvY2F0ZWQuDQo+IA0KPiBUaGFu a3MNCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBkZXZlbEBl ZGsyLmdyb3Vwcy5pbw0KPiBbbWFpbHRvOmRldmVsQGVkazIuZ3JvdXBzLmlvXSBPbiBCZWhhbGYg T2YNCj4gPiBNaWNoYWVsIEQgS2lubmV5DQo+ID4gU2VudDogV2VkbmVzZGF5LCBNYXJjaCAxOCwg MjAyMCAxMToxNSBQTQ0KPiA+IFRvOiBYdSwgV2VpNiA8d2VpNi54dUBpbnRlbC5jb20+Ow0KPiBk ZXZlbEBlZGsyLmdyb3Vwcy5pbzsgS2lubmV5LCBNaWNoYWVsDQo+ID4gRCA8bWljaGFlbC5kLmtp bm5leUBpbnRlbC5jb20+DQo+ID4gQ2M6IEt1biBRaW4gPGt1cWluQG1pY3Jvc29mdC5jb20+OyBH YW8sIExpbWluZw0KPiA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4gU3ViamVjdDogUmU6IFtl ZGsyLWRldmVsXSBbUEFUQ0hdDQo+IEZtcERldmljZVBrZy9GbXBEeGU6IEZpeCB1bmluaXRpYWxp emVkDQo+ID4gcG9pbnRlciBkZXJlZmVyZW5jZQ0KPiA+DQo+ID4gUmV2aWV3ZWQtYnk6IE1pY2hh ZWwgRCBLaW5uZXkNCj4gPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPg0KPiA+DQo+ID4gPiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogWHUsIFdlaTYgPHdlaTYueHVA aW50ZWwuY29tPg0KPiA+ID4gU2VudDogVHVlc2RheSwgTWFyY2ggMTcsIDIwMjAgMTE6MTIgUE0N Cj4gPiA+IFRvOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbw0KPiA+ID4gQ2M6IEt1biBRaW4gPGt1cWlu QG1pY3Jvc29mdC5jb20+OyBLaW5uZXksIE1pY2hhZWwNCj4gRA0KPiA+ID4gPG1pY2hhZWwuZC5r aW5uZXlAaW50ZWwuY29tPjsgR2FvLCBMaW1pbmcNCj4gPGxpbWluZy5nYW9AaW50ZWwuY29tPg0K PiA+ID4gU3ViamVjdDogW2VkazItZGV2ZWxdIFtQQVRDSF0gRm1wRGV2aWNlUGtnL0ZtcER4ZToN Cj4gRml4IHVuaW5pdGlhbGl6ZWQNCj4gPiA+IHBvaW50ZXIgZGVyZWZlcmVuY2UNCj4gPiA+DQo+ ID4gPiBGcm9tOiBLdW4gUWluIDxrdXFpbkBtaWNyb3NvZnQuY29tPg0KPiA+ID4NCj4gPiA+IFJF RjoNCj4gPiA+IGh0dHBzOi8vYnVnemlsbGEudGlhbm9jb3JlLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjYwMg0KPiA+ID4NCj4gPiA+IFplcm8gdGhlIGFsbG9jYXRlZCBidWZmZXIgaW4gY2FzZSBHZXRJ bWFnZUluZm8NCj4gYGNvbnRpbnVlYCBpbiB0aGUNCj4gPiA+IG1pZGRsZSBvZiBhIGxvb3AuIFRo aXMgd2lsbCBjYXVzZSB1bmV4cGVjdGVkDQo+IEdldEltYWdlSW5mbyBmYWlsdXJlIG5vdA0KPiA+ ID4gY2xlYXJpbmcgdGhlIGNvcnJlc3BvbmRpbmcgZW50cnkgYW5kIGxlYWQgdG8gR1ANCj4gZmF1 bHRzIHdoZW4NCj4gPiA+IGRlcmVmZXJlbmNpbmcgdGhpcyBlbnRyeS4NCj4gPiA+DQo+ID4gPiBD YzogTWljaGFlbCBEIEtpbm5leSA8bWljaGFlbC5kLmtpbm5leUBpbnRlbC5jb20+DQo+ID4gPiBD YzogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBXZWk2IFh1IDx3ZWk2Lnh1QGludGVsLmNvbT4NCj4gPiA+IC0tLQ0KPiA+ID4gIEZtcERldmlj ZVBrZy9GbXBEeGUvRGVwZW5kZW5jeS5jIHwgMiArLQ0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiA+ID4NCj4gPiA+IGRpZmYgLS1naXQgYS9G bXBEZXZpY2VQa2cvRm1wRHhlL0RlcGVuZGVuY3kuYw0KPiA+ID4gYi9GbXBEZXZpY2VQa2cvRm1w RHhlL0RlcGVuZGVuY3kuYw0KPiA+ID4gaW5kZXggOGY5N2M0MjkxNi4uNjVjMjM5ODljNiAxMDA2 NDQNCj4gPiA+IC0tLSBhL0ZtcERldmljZVBrZy9GbXBEeGUvRGVwZW5kZW5jeS5jDQo+ID4gPiAr KysgYi9GbXBEZXZpY2VQa2cvRm1wRHhlL0RlcGVuZGVuY3kuYw0KPiA+ID4gQEAgLTU1MCwxMSAr NTUwLDExIEBAIEV2YWx1YXRlSW1hZ2VEZXBlbmRlbmNpZXMgKA0KPiA+ID4gICAgICAgICAgICAg ICAgICApOw0KPiA+ID4gICAgaWYgKEVGSV9FUlJPUiAoU3RhdHVzKSkgew0KPiA+ID4gICAgICBy ZXR1cm4gRUZJX0FCT1JURUQ7DQo+ID4gPiAgICB9DQo+ID4gPg0KPiA+ID4gLSAgbUZtcEltYWdl SW5mb0J1ZiA9IEFsbG9jYXRlUG9vbA0KPiA+ID4gKHNpemVvZihFRklfRklSTVdBUkVfSU1BR0Vf REVTQ1JJUFRPUiAqKSAqDQo+ID4gbU51bWJlck9mRm1wSW5zdGFuY2UpOw0KPiA+ID4gKyAgbUZt cEltYWdlSW5mb0J1ZiA9IEFsbG9jYXRlWmVyb1Bvb2wNCj4gPiA+IChzaXplb2YoRUZJX0ZJUk1X QVJFX0lNQUdFX0RFU0NSSVBUT1IgKikgKg0KPiA+IG1OdW1iZXJPZkZtcEluc3RhbmNlKTsNCj4g PiA+ICAgIGlmIChtRm1wSW1hZ2VJbmZvQnVmID09IE5VTEwpIHsNCj4gPiA+ICAgICAgcmV0dXJu IEVGSV9PVVRfT0ZfUkVTT1VSQ0VTOw0KPiA+ID4gICAgfQ0KPiA+ID4NCj4gPiA+ICAgIGZvciAo SW5kZXggPSAwOyBJbmRleCA8IG1OdW1iZXJPZkZtcEluc3RhbmNlOw0KPiBJbmRleA0KPiA+ID4g KyspIHsNCj4gPiA+IC0tDQo+ID4gPiAyLjE2LjIud2luZG93cy4xDQo+ID4NCj4gPg0KPiA+IA0K DQo=