Re: [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData

["Michael D Kinney" <michael.d.kinney@intel.com>]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Monday, March 23, 2020 6:43 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v4] MdePkg/UnitTestBaseLib: Add check
> for pointer BinData
> 
> REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2531
> 
> AllocatePool may fail and BinData may be invalid, check
> it before use.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> index 6f7c31cab4..8952f9da6c 100644
> ---
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> +++
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> @@ -252,9 +252,11 @@ RfcDecodeTest(
>    BinSize = AsciiStrnLenS (binString,
> MAX_TEST_STRING_SIZE);
> 
> 
> 
>    BinData = AllocatePool (BinSize);
> 
> -  Btc->BufferToFree = BinData;
> 
> +  UT_ASSERT_NOT_NULL(BinData);
> 
> 
> 
> +  Btc->BufferToFree = BinData;
> 
>    ReturnSize = BinSize;
> 
> +
> 
>    Status = Base64Decode (b64String, b64StringLen,
> BinData, &ReturnSize);
> 
> 
> 
>    UT_ASSERT_STATUS_EQUAL (Status, Btc-
> >ExpectedStatus);
> 
> --
> 2.25.1.windows.1