From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web11.2914.1676624949409581210
 for <devel@edk2.groups.io>;
 Fri, 17 Feb 2023 01:09:10 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=q0A5rPrb;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 8AE18240368
	for <devel@edk2.groups.io>; Fri, 17 Feb 2023 10:09:07 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1676624947; bh=1m3LUZblymuK8WIXZxl7dXYdEp8vSz0rKbVZqY2x6pA=;
	h=From:Subject:Date:Cc:To:From;
	b=q0A5rPrbby9l2rybUHk28L94pRfrRueCiQDrZTGC197VjaakdRbWOVwZWaIG5A/Fu
	 z3FkSh/ZpXr5i4NhSlfhDaVWxQChoHr425knfRrxx3YQ01HOJNI237HXG/SeGk/BiR
	 c5E+Qmixl2RekisYspNuWf11W63wsxunaRAi2JqBi8fQGz4Cf3Kh7RNsncfyxMQLXZ
	 UjCFSP+nZqU79ByzL9YYFUm4nlHxxuDYXEk6xxJ0CZMI8lfgSBRFgYf2rh63Mr7Nwj
	 gdjq6K0NHeMXOS4/xmgUpqRMBz8jndEadBCCrdWssxMz4XmjtZS2pV5G5LNSylQNBg
	 q+Uy4pHsOnQcg==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4PJ5bQ2WTrz9rxN;
	Fri, 17 Feb 2023 10:09:06 +0100 (CET)
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink
Date: Fri, 17 Feb 2023 09:09:05 +0000
Message-Id: <EAA4F06B-855F-492D-936F-09071178DECB@posteo.de>
References: <20230217085647.70781-1-savvamtr@gmail.com>
Cc: devel@edk2.groups.io, Pedro Falcato <pedro.falcato@gmail.com>,
 Vitaly Cheptsov <vit9696@protonmail.com>
In-Reply-To: <20230217085647.70781-1-savvamtr@gmail.com>
To: Savva Mitrofanov <savvamtr@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>

> On 17. Feb 2023, at 09:56, Savva Mitrofanov <savvamtr@gmail.com> wrote:
>=20
> =EF=BB=BFThe SymlinkTmp was deallocated unconditionally, so we shouldn't f=
ree it
> again on EFI_ERROR
>=20
> Cc: Marvin H=C3=A4user <mhaeuser@posteo.de>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support")
> Signed-off-by: Savva Mitrofanov <savvamtr@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 -
> 1 file changed, 1 deletion(-)
>=20
> diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe=
/Symlink.c
> index 1189a99ded2b..d80cb9fff92e 100644
> --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c
> @@ -243,7 +243,6 @@ Ext4ReadSymlink (
>       Status
>       ));
>     FreePool (Symlink16Tmp);
> -    FreePool (SymlinkTmp);
>     return Status;
>   }
>=20
> --=20
> 2.39.1
>=20