Re: [PATCH v2 4/4] ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc

["Marvin Häuser" <mhaeuser@posteo.de>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

@Reviewers: In case there are concerns regarding remaining users - to me, it appears the old RVD code has been broken for a very long time anyway: https://github.com/mhaeuser/edk2/commit/fc7b6713ec8772622eeb3f579914f5f15a86e1ee

Thanks, Rebecca!

Best regards,
Marvin

> On 27. Jan 2023, at 17:42, Rebecca Cran <rebecca@bsdio.com> wrote:
> 
> Since RvdPeCoffExtraActionLib has been deleted, remove lines referencing
> it and the RealView Debugger from ArmVirtPkg.dsc.inc.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 7 -------
> 1 file changed, 7 deletions(-)
> 
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 462073517a22..74d98e6314c4 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -122,13 +122,6 @@ [LibraryClasses.common]
>   PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>   SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortLib.inf
> 
> -  #
> -  # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> -  # in the debugger will show load and unload commands for symbols. You can cut and paste this
> -  # into the command window to load symbols. We should be able to use a script to do this, but
> -  # the version of RVD I have does not support scripts accessing system memory.
> -  #
> -  #PeCoffExtraActionLib|ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf
>   PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf
>   #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
> 
> -- 
> 2.34.1
> 


[-- Attachment #2: Type: text/html, Size: 2302 bytes --]