From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.107123.1674838007045123472 for ; Fri, 27 Jan 2023 08:46:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@posteo.de header.s=2017 header.b=WPoMUm7L; spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 29D7B240045 for ; Fri, 27 Jan 2023 17:46:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1674838005; bh=QktfpVNAskr3BibUstlLXah5bb+ym3KSVAbT0IjNym0=; h=From:Subject:Date:Cc:To:From; b=WPoMUm7LFZWR0sVtaaiUs0AWR5W4Le2pT1MnOMT39j4UNmLbOn+JO1mXt73d5vYwU yFLeEqyCxQu/JjKTZ0QQs1aang80eQTgnOFigx5otrgpvNV2VHoy09nRG9Yj9JMM7R u2jUAqpPfKcsgn6ZIjP9+0DVU4XEurZkyTZI9Su0iYXZRf8aZFPI035z0QCFBEwOBp BsoZY9o3W6GsUsAOzmZWm9ZQnyn725ZJMFM6DfIwAaHAFBMCzDhrTzqByRs8KliQU3 bZtd+3VrA65jI+s9Puu9D8RXO/ksyA47Aep/DgA08yW9bQnC/VnsLgqKurniZasxIz m9bsbVhfnQnFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4P3Nl6484jz6tmB; Fri, 27 Jan 2023 17:46:42 +0100 (CET) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= Message-Id: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: [PATCH v2 4/4] ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc Date: Fri, 27 Jan 2023 16:46:32 +0000 In-Reply-To: <20230127164251.92227-5-rebecca@bsdio.com> Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , Bob Feng , Liming Gao , Yuwei Chen To: Rebecca Cran References: <20230127164251.92227-1-rebecca@bsdio.com> <20230127164251.92227-5-rebecca@bsdio.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_3F73C7DB-753E-4E1F-9836-13E28BE4EA83" --Apple-Mail=_3F73C7DB-753E-4E1F-9836-13E28BE4EA83 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii @Reviewers: In case there are concerns regarding remaining users - to = me, it appears the old RVD code has been broken for a very long time = anyway: = https://github.com/mhaeuser/edk2/commit/fc7b6713ec8772622eeb3f579914f5f15a= 86e1ee Thanks, Rebecca! Best regards, Marvin > On 27. Jan 2023, at 17:42, Rebecca Cran wrote: >=20 > Since RvdPeCoffExtraActionLib has been deleted, remove lines = referencing > it and the RealView Debugger from ArmVirtPkg.dsc.inc. >=20 > Signed-off-by: Rebecca Cran > --- > ArmVirtPkg/ArmVirt.dsc.inc | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 462073517a22..74d98e6314c4 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -122,13 +122,6 @@ [LibraryClasses.common] > PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf > = SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL011SerialPortL= ib.inf >=20 > - # > - # Uncomment (and comment out the next line) For RealView Debugger. = The Standard IO window > - # in the debugger will show load and unload commands for symbols. = You can cut and paste this > - # into the command window to load symbols. We should be able to use = a script to do this, but > - # the version of RVD I have does not support scripts accessing = system memory. > - # > - = #PeCoffExtraActionLib|ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtr= aActionLib.inf > = PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffE= xtraActionLib.inf > = #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCo= ffExtraActionLibNull.inf >=20 > --=20 > 2.34.1 >=20 --Apple-Mail=_3F73C7DB-753E-4E1F-9836-13E28BE4EA83 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii @Reviewers: In = case there are concerns regarding remaining users - to me, it appears = the old RVD code has been broken for a very long time anyway: https://github.com/mhaeuser/edk2/commit/fc7b6713ec8772622e= eb3f579914f5f15a86e1ee

Thanks, = Rebecca!

Best = regards,
Marvin

On = 27. Jan 2023, at 17:42, Rebecca Cran <rebecca@bsdio.com> = wrote:

Since = RvdPeCoffExtraActionLib has been deleted, remove lines referencing
it = and the RealView Debugger from ArmVirtPkg.dsc.inc.

Signed-off-by: = Rebecca Cran <rebecca@bsdio.com>
---
= ArmVirtPkg/ArmVirt.dsc.inc | 7 -------
1 file changed, 7 = deletions(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc = b/ArmVirtPkg/ArmVirt.dsc.inc
index 462073517a22..74d98e6314c4 = 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ = b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -122,13 +122,6 @@ = [LibraryClasses.common]
=   PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.= inf
=   SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/FdtPL01= 1SerialPortLib.inf

-  #
-  # Uncomment (and comment = out the next line) For RealView Debugger. The Standard IO window
- =  # in the debugger will show load and unload commands for symbols. = You can cut and paste this
-  # into the command window to load = symbols. We should be able to use a script to do this, but
-  # = the version of RVD I have does not support scripts accessing system = memory.
-  #
- =  #PeCoffExtraActionLib|ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCo= ffExtraActionLib.inf
=   PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/= DebugPeCoffExtraActionLib.inf
=   #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibN= ull/BasePeCoffExtraActionLibNull.inf

-- =
2.34.1


= --Apple-Mail=_3F73C7DB-753E-4E1F-9836-13E28BE4EA83--