From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 50D3C1A1E59 for ; Thu, 8 Sep 2016 19:17:50 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 08 Sep 2016 19:17:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,303,1470726000"; d="scan'208";a="1027202678" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 08 Sep 2016 19:17:49 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Sep 2016 19:17:49 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Sep 2016 19:17:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0248.002; Fri, 9 Sep 2016 10:17:46 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [patch] MdeModulePkg/UiApp: Fix incorrect question id Thread-Index: AQHSCbDaZXBKrU4P90GrcOwkqHz9x6BwbT7A Date: Fri, 9 Sep 2016 02:17:45 +0000 Message-ID: References: <1473325798-24284-1-git-send-email-dandan.bi@intel.com> <1473325798-24284-2-git-send-email-dandan.bi@intel.com> In-Reply-To: <1473325798-24284-2-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/UiApp: Fix incorrect question id X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 02:17:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, September 08, 2016 5:10 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/UiApp: Fix incorrect question id >=20 > For a question, its question id can not be zero. > This patch is to fix the issue that using zero as question id. >=20 > Cc: Liming Gao > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.= c > b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > index 93f6e4e..1505ef9 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > +++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c > @@ -41,10 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EI= THER EXPRESS OR IMPLIED. > #define UI_HII_DRIVER_LIST_SIZE 0x8 >=20 > #define FRONT_PAGE_KEY_CONTINUE 0x1000 > #define FRONT_PAGE_KEY_RESET 0x1001 > #define FRONT_PAGE_KEY_LANGUAGE 0x1002 > +#define FRONT_PAGE_KEY_DRIVER 0x2000 >=20 > typedef struct { > EFI_STRING_ID PromptId; > EFI_STRING_ID HelpId; > EFI_STRING_ID DevicePathId; > @@ -654,11 +655,11 @@ UiListThirdPartyDrivers ( > StartOpCodeHandle, > 0, > gHiiDriverList[Index].PromptId, > gHiiDriverList[Index].HelpId, > 0, > - 0, > + (EFI_QUESTION_ID) (Index + FRONT_PAGE_KEY_DRIVER), > 0, > &gHiiDriverList[Index].FormSetGuid, > gHiiDriverList[Index].DevicePathId > ); >=20 > -- > 1.9.5.msysgit.1