From: "Dong, Eric" <eric.dong@intel.com>
To: 'Felix Poludov' <Felixp@ami.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>, "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [RFC] [MdePkg] UefiLib: CreatePopUp
Date: Fri, 28 Oct 2016 02:35:37 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E662248685985@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <9333E191E0D52B4999CE63A99BA663A00270FF754E@atlms1.us.megatrends.com>
Hi Felix,
Do you want to provide a new solution for CreatePopup or just want to split CreatePopup from UefiLib? We already has a proposal to provide new API to replace CreatePopup. This new API will use modal form to paint the UI. Detail you can see the proposal in below link:
https://github.com/ydong10/doc/blob/master/Use%20Modal%20form%20for%20CreatePopup%20API.pptx
Thanks,
Eric
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Felix Poludov
> Sent: Friday, October 28, 2016 5:12 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp
>
> UefiLib library class (MdePkg ) includes CreatePopUp function.
> The function displays a message box.
> There is certainly more than one way to draw a message box.
> If homogenous user interface is a project requirement,
> CreatePopUp is likely to be overridden to align message box appearance with the platform look and feel.
> The function can be overridden by creating a project specific UefiLib instance, but this seems like an overkill
> because the rest of the UefiLib, which is quite big, would have to be duplicated.
>
> One way to solve the problem is to move CreatePopUp to a new library class, however, this may break existing projects.
> I suggest changing CreatePopUp implementation to delegate pop up drawing to a new
> function UiCreatePopUp provided by a new library class UiLib.h.
>
> I would like to solicit feedback for this proposal.
> If there will be no major objections, I'll start working on a patch.
>
> Thanks
> Felix
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is
> intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the
> intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the
> sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-10-28 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 21:11 [RFC] [MdePkg] UefiLib: CreatePopUp Felix Poludov
2016-10-28 2:35 ` Dong, Eric [this message]
2016-10-28 13:52 ` Felix Poludov
2016-10-31 8:25 ` Dong, Eric
2016-10-31 20:22 ` Felix Poludov
2016-11-01 6:54 ` Dong, Eric
2016-11-02 23:12 ` Felix Poludov
2016-11-03 7:32 ` Dong, Eric
2016-11-03 23:25 ` Yao, Jiewen
2016-11-04 20:15 ` Felix Poludov
2016-11-03 23:55 ` Felix Poludov
2016-11-04 2:39 ` Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E662248685985@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox