From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C29C181CE5 for ; Mon, 31 Oct 2016 01:25:51 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 31 Oct 2016 01:25:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,426,1473145200"; d="scan'208";a="1078314309" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 31 Oct 2016 01:25:52 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 01:25:52 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 01:25:51 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Mon, 31 Oct 2016 16:25:49 +0800 From: "Dong, Eric" To: Felix Poludov , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Bi, Dandan" Thread-Topic: [RFC] [MdePkg] UefiLib: CreatePopUp Thread-Index: AdIwjdjhOCSq+FCtTKCTGmtOXAGI2QAMMLIgABg3kNAAjBbicA== Date: Mon, 31 Oct 2016 08:25:49 +0000 Message-ID: References: <9333E191E0D52B4999CE63A99BA663A00270FF754E@atlms1.us.megatrends.com> <9333E191E0D52B4999CE63A99BA663A00270FF787F@atlms1.us.megatrends.com> In-Reply-To: <9333E191E0D52B4999CE63A99BA663A00270FF787F@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [RFC] [MdePkg] UefiLib: CreatePopUp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Oct 2016 08:25:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Felix, Add my comments below. > -----Original Message----- > From: Felix Poludov [mailto:Felixp@ami.com] > Sent: Friday, October 28, 2016 9:52 PM > To: Dong, Eric; edk2-devel@lists.01.org > Cc: Gao, Liming; Bi, Dandan > Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp >=20 > Hi Eric, >=20 > My goal is to facilitate CreatePopUp customization. > Since UI is one of the most customizable areas in the firmware projects, = an ability to easily replace UI element would be useful. > Thank you for providing the presentation. > I agree with the problem statement. It describes some of the reasons behi= nd my request. > As far as the solution you propose, you are introducing a new function Hi= iGetUserSelection, which is more powerful, but still implements a > specific look-and-feel. > So it should be possible to easily replace HiiGetUserSelection with a pro= ject specific version to align implementation with project-specific > UI. > Which library class are you planning to add HiiGetUserSelection to? [[Eric]] I plan to add this API to HiiLib which existed at MdeModulePkg/Lib= rary/UefiHiiLib. I think it's belong to HII scope. > Another question is, what are you planning to do with the existing Create= PopUp function? [[Eric]] I plan to not change it. Just suggest user to use new API and depr= ecated it later. > If you just remove it, existing projects that use the function will break= . > With my proposal, CreatePopUp can be easily replaced by picking a differe= nt library instance. > For example, we can have a legacy instance that implements current behavi= or as well as and advanced instance that implements popup > using HII infrastructure. >=20 > Thanks > Felix >=20 > -----Original Message----- > From: Dong, Eric [mailto:eric.dong@intel.com] > Sent: Thursday, October 27, 2016 10:36 PM > To: Felix Poludov; edk2-devel@lists.01.org > Cc: Gao, Liming; Bi, Dandan > Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp >=20 > Hi Felix, >=20 > Do you want to provide a new solution for CreatePopup or just want to spl= it CreatePopup from UefiLib? We already has a proposal to > provide new API to replace CreatePopup. This new API will use modal form = to paint the UI. Detail you can see the proposal in below link: > https://github.com/ydong10/doc/blob/master/Use%20Modal%20form%20for%20Cre= atePopup%20API.pptx >=20 > Thanks, > Eric > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of = Felix Poludov > > Sent: Friday, October 28, 2016 5:12 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp > > > > UefiLib library class (MdePkg ) includes CreatePopUp function. > > The function displays a message box. > > There is certainly more than one way to draw a message box. > > If homogenous user interface is a project requirement, > > CreatePopUp is likely to be overridden to align message box appearance = with the platform look and feel. > > The function can be overridden by creating a project specific UefiLib i= nstance, but this seems like an overkill > > because the rest of the UefiLib, which is quite big, would have to be d= uplicated. > > > > One way to solve the problem is to move CreatePopUp to a new library cl= ass, however, this may break existing projects. > > I suggest changing CreatePopUp implementation to delegate pop up drawin= g to a new > > function UiCreatePopUp provided by a new library class UiLib.h. > > > > I would like to solicit feedback for this proposal. > > If there will be no major objections, I'll start working on a patch. > > > > Thanks > > Felix > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and propr= ietary to American Megatrends, Inc. This communication is > > intended to be read only by the individual or entity to whom it is addr= essed or by their designee. If the reader of this message is not the > > intended recipient, you are on notice that any distribution of this mes= sage, in any form, is strictly prohibited. Please promptly notify the > > sender by reply e-mail or by telephone at 770-246-8600, and then delete= or destroy all copies of the transmission. > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and proprie= tary to American Megatrends, Inc. This communication is > intended to be read only by the individual or entity to whom it is addres= sed or by their designee. If the reader of this message is not the > intended recipient, you are on notice that any distribution of this messa= ge, in any form, is strictly prohibited. Please promptly notify the > sender by reply e-mail or by telephone at 770-246-8600, and then delete o= r destroy all copies of the transmission.