Re: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED.

["Dong, Eric" <eric.dong@intel.com>]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Tuesday, November 29, 2016 12:56 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED.
> 
> According to UEFI spec, unsupported function should return EFI_UNSUPPORTED
> directly.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  .../Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
> index 642a99d..60490a4 100644
> --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
> +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
> @@ -178,18 +178,6 @@ FmpGetImage (
>    IN  OUT  UINTN                        *ImageSize
>    )
>  {
> -  SYSTEM_FMP_PRIVATE_DATA *SystemFmpPrivate;
> -
> -  if (Image == NULL || ImageSize == NULL) {
> -    return EFI_INVALID_PARAMETER;
> -  }
> -
> -  SystemFmpPrivate = SYSTEM_FMP_PRIVATE_DATA_FROM_FMP(This);
> -
> -  if (ImageIndex == 0 || ImageIndex > SystemFmpPrivate->DescriptorCount || ImageSize == NULL || Image == NULL) {
> -    return EFI_INVALID_PARAMETER;
> -  }
> -
>    return EFI_UNSUPPORTED;
>  }
> 
> --
> 2.7.4.windows.1