From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E5CD381C99 for ; Mon, 28 Nov 2016 21:14:01 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 28 Nov 2016 21:14:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,714,1473145200"; d="scan'208";a="10853004" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 28 Nov 2016 21:14:01 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 28 Nov 2016 21:14:01 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 28 Nov 2016 21:14:00 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Tue, 29 Nov 2016 13:13:58 +0800 From: "Dong, Eric" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED. Thread-Index: AQHSSfzswzEWz4DRr0q1YsKEcC3Iu6DvarFw Date: Tue, 29 Nov 2016 05:13:58 +0000 Message-ID: References: <1480395368-13524-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1480395368-13524-1-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 05:14:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, November 29, 2016 12:56 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED. >=20 > According to UEFI spec, unsupported function should return EFI_UNSUPPORTE= D > directly. >=20 > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > --- > .../Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 12 ------= ------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwa= reCommonDxe.c > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe= .c > index 642a99d..60490a4 100644 > --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommo= nDxe.c > +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommo= nDxe.c > @@ -178,18 +178,6 @@ FmpGetImage ( > IN OUT UINTN *ImageSize > ) > { > - SYSTEM_FMP_PRIVATE_DATA *SystemFmpPrivate; > - > - if (Image =3D=3D NULL || ImageSize =3D=3D NULL) { > - return EFI_INVALID_PARAMETER; > - } > - > - SystemFmpPrivate =3D SYSTEM_FMP_PRIVATE_DATA_FROM_FMP(This); > - > - if (ImageIndex =3D=3D 0 || ImageIndex > SystemFmpPrivate->DescriptorCo= unt || ImageSize =3D=3D NULL || Image =3D=3D NULL) { > - return EFI_INVALID_PARAMETER; > - } > - > return EFI_UNSUPPORTED; > } >=20 > -- > 2.7.4.windows.1