From: "Dong, Eric" <eric.dong@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used
Date: Tue, 6 Dec 2016 07:25:00 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E6622486AE852@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1480938055-45116-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Monday, December 05, 2016 7:41 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=280
>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> index 451fd03..06e682a 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> @@ -3533,10 +3533,11 @@ SubmitForSystem (
> VOID
> )
> {
> EFI_STATUS Status;
> LIST_ENTRY *Link;
> + LIST_ENTRY *FormLink;
> LIST_ENTRY *StorageLink;
> FORMSET_STORAGE *FormSetStorage;
> FORM_BROWSER_FORM *Form;
> FORM_BROWSER_FORMSET *LocalFormSet;
> UINT32 UserSelection;
> @@ -3623,14 +3624,14 @@ SubmitForSystem (
> FormSetStorage->SyncConfigRequest = NULL;
> }
> }
> }
>
> - Link = GetFirstNode (&LocalFormSet->FormListHead);
> - while (!IsNull (&LocalFormSet->FormListHead, Link)) {
> - Form = FORM_BROWSER_FORM_FROM_LINK (Link);
> - Link = GetNextNode (&LocalFormSet->FormListHead, Link);
> + FormLink = GetFirstNode (&LocalFormSet->FormListHead);
> + while (!IsNull (&LocalFormSet->FormListHead, FormLink)) {
> + Form = FORM_BROWSER_FORM_FROM_LINK (FormLink);
> + FormLink = GetNextNode (&LocalFormSet->FormListHead, FormLink);
> //
> // Call callback with Changed type to inform the driver.
> //
> SendDiscardInfoToDriver (LocalFormSet, Form);
> }
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-12-06 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 11:40 [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used Dandan Bi
2016-12-06 7:25 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E6622486AE852@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox