From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B33D81FD5 for ; Mon, 5 Dec 2016 23:25:04 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 05 Dec 2016 23:25:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,751,1477983600"; d="scan'208";a="39343034" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 05 Dec 2016 23:25:03 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 5 Dec 2016 23:25:03 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Tue, 6 Dec 2016 15:25:01 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used Thread-Index: AQHSTuyHBJuN6txqD0yWscBXkUCQd6D6hcgQ Date: Tue, 6 Dec 2016 07:25:00 +0000 Message-ID: References: <1480938055-45116-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1480938055-45116-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 07:25:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Da= ndan Bi > Sent: Monday, December 05, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local= variable used >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D280 >=20 > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePk= g/Universal/SetupBrowserDxe/Setup.c > index 451fd03..06e682a 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > @@ -3533,10 +3533,11 @@ SubmitForSystem ( > VOID > ) > { > EFI_STATUS Status; > LIST_ENTRY *Link; > + LIST_ENTRY *FormLink; > LIST_ENTRY *StorageLink; > FORMSET_STORAGE *FormSetStorage; > FORM_BROWSER_FORM *Form; > FORM_BROWSER_FORMSET *LocalFormSet; > UINT32 UserSelection; > @@ -3623,14 +3624,14 @@ SubmitForSystem ( > FormSetStorage->SyncConfigRequest =3D NULL; > } > } > } >=20 > - Link =3D GetFirstNode (&LocalFormSet->FormListHead); > - while (!IsNull (&LocalFormSet->FormListHead, Link)) { > - Form =3D FORM_BROWSER_FORM_FROM_LINK (Link); > - Link =3D GetNextNode (&LocalFormSet->FormListHead, Link); > + FormLink =3D GetFirstNode (&LocalFormSet->FormListHead); > + while (!IsNull (&LocalFormSet->FormListHead, FormLink)) { > + Form =3D FORM_BROWSER_FORM_FROM_LINK (FormLink); > + FormLink =3D GetNextNode (&LocalFormSet->FormListHead, FormLink)= ; > // > // Call callback with Changed type to inform the driver. > // > SendDiscardInfoToDriver (LocalFormSet, Form); > } > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel