[patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used

[patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used

[Dandan Bi]

https://bugzilla.tianocore.org/show_bug.cgi?id=280

Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index 451fd03..06e682a 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -3533,10 +3533,11 @@ SubmitForSystem (
   VOID
   )
 {
   EFI_STATUS              Status;
   LIST_ENTRY              *Link;
+  LIST_ENTRY              *FormLink;
   LIST_ENTRY              *StorageLink;
   FORMSET_STORAGE         *FormSetStorage;
   FORM_BROWSER_FORM       *Form;
   FORM_BROWSER_FORMSET    *LocalFormSet;
   UINT32                  UserSelection;
@@ -3623,14 +3624,14 @@ SubmitForSystem (
             FormSetStorage->SyncConfigRequest = NULL;
           }
         }
       }
 
-      Link = GetFirstNode (&LocalFormSet->FormListHead);
-      while (!IsNull (&LocalFormSet->FormListHead, Link)) {
-        Form = FORM_BROWSER_FORM_FROM_LINK (Link);
-        Link = GetNextNode (&LocalFormSet->FormListHead, Link);
+      FormLink = GetFirstNode (&LocalFormSet->FormListHead);
+      while (!IsNull (&LocalFormSet->FormListHead, FormLink)) {
+        Form = FORM_BROWSER_FORM_FROM_LINK (FormLink);
+        FormLink = GetNextNode (&LocalFormSet->FormListHead, FormLink);
         //
         // Call callback with Changed type to inform the driver.
         //
         SendDiscardInfoToDriver (LocalFormSet, Form);
       }
-- 
1.9.5.msysgit.1

Re: [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Monday, December 05, 2016 7:41 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [edk2] [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=280
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> index 451fd03..06e682a 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
> @@ -3533,10 +3533,11 @@ SubmitForSystem (
>    VOID
>    )
>  {
>    EFI_STATUS              Status;
>    LIST_ENTRY              *Link;
> +  LIST_ENTRY              *FormLink;
>    LIST_ENTRY              *StorageLink;
>    FORMSET_STORAGE         *FormSetStorage;
>    FORM_BROWSER_FORM       *Form;
>    FORM_BROWSER_FORMSET    *LocalFormSet;
>    UINT32                  UserSelection;
> @@ -3623,14 +3624,14 @@ SubmitForSystem (
>              FormSetStorage->SyncConfigRequest = NULL;
>            }
>          }
>        }
> 
> -      Link = GetFirstNode (&LocalFormSet->FormListHead);
> -      while (!IsNull (&LocalFormSet->FormListHead, Link)) {
> -        Form = FORM_BROWSER_FORM_FROM_LINK (Link);
> -        Link = GetNextNode (&LocalFormSet->FormListHead, Link);
> +      FormLink = GetFirstNode (&LocalFormSet->FormListHead);
> +      while (!IsNull (&LocalFormSet->FormListHead, FormLink)) {
> +        Form = FORM_BROWSER_FORM_FROM_LINK (FormLink);
> +        FormLink = GetNextNode (&LocalFormSet->FormListHead, FormLink);
>          //
>          // Call callback with Changed type to inform the driver.
>          //
>          SendDiscardInfoToDriver (LocalFormSet, Form);
>        }
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel