public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dong, Eric" <eric.dong@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function
Date: Wed, 14 Dec 2016 05:18:39 +0000	[thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224A8B265C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1481618428-101904-8-git-send-email-dandan.bi@intel.com>

Please also update the function comment to "Send BlockSid request through TPM physical presence module."
With this change, the patch is good.

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zhang, Chao B
> Subject: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> index 4f82c1c..74d1c1f 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> @@ -1174,11 +1174,11 @@ HiiPasswordEntered(
>  }
> 
>  /**
>    Update block sid info.
> 
> -  @param      Enable         Enable/disable BlockSid.
> +  @param   PpRequest         TPM physical presence operation request.
> 
>    @retval  EFI_SUCCESS       Do the required action success.
>    @retval  Others            Other error occur.
> 
>  **/
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-12-14  5:18 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  8:40 [patch 00/18] Fix coding style issues Dandan Bi
2016-12-13  8:40 ` [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: " Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: " Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DCA@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:45     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format Dandan Bi
2016-12-13  8:50   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues Dandan Bi
2016-12-13  8:50   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Dandan Bi
2016-12-14  5:18   ` Dong, Eric [this message]
2016-12-13  8:40 ` [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to " Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: " Dandan Bi
2016-12-13  8:48   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen
2016-12-14  2:36     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 12/18] UefiCpuPkg: Make the comments align with the functions Dandan Bi
2016-12-14  2:50   ` Fan, Jeff
2016-12-13  8:40 ` [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:41     ` Yao, Jiewen
2016-12-14  2:51   ` Fan, Jeff
2016-12-13  8:40 ` [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues Dandan Bi
2016-12-13  8:47   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 16/18] MdeModulePkg: Make the comments align with the function Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 17/18] MdeModulePkg: Add missing info string for PCDs Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DD7@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:42     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED077930C258884BBCB450DB737E66224A8B265C@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox