From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B115821E8 for ; Tue, 13 Dec 2016 21:18:45 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 13 Dec 2016 21:18:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="42378833" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 13 Dec 2016 21:18:44 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 21:18:44 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 21:18:43 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.97]) by shsmsx102.ccr.corp.intel.com ([169.254.2.54]) with mapi id 14.03.0248.002; Wed, 14 Dec 2016 13:18:39 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" Thread-Topic: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Thread-Index: AQHSVRzvzdFjl0E940yXz+Wk1baAu6EG5/nQ Date: Wed, 14 Dec 2016 05:18:39 +0000 Message-ID: References: <1481618428-101904-1-git-send-email-dandan.bi@intel.com> <1481618428-101904-8-git-send-email-dandan.bi@intel.com> In-Reply-To: <1481618428-101904-8-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 05:18:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please also update the function comment to "Send BlockSid request through T= PM physical presence module." With this change, the patch is good. Reviewed-by: Eric Dong > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, December 13, 2016 4:40 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Zhang, Chao B > Subject: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align w= ith the function >=20 > Cc: Eric Dong > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg= /Tcg/Opal/OpalPasswordDxe/OpalHii.c > index 4f82c1c..74d1c1f 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c > +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c > @@ -1174,11 +1174,11 @@ HiiPasswordEntered( > } >=20 > /** > Update block sid info. >=20 > - @param Enable Enable/disable BlockSid. > + @param PpRequest TPM physical presence operation request. >=20 > @retval EFI_SUCCESS Do the required action success. > @retval Others Other error occur. >=20 > **/ > -- > 1.9.5.msysgit.1