From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D28FA2041D9EF for ; Thu, 30 Mar 2017 00:52:39 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 30 Mar 2017 00:52:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,245,1486454400"; d="scan'208";a="82619674" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2017 00:52:39 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 00:52:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 00:52:39 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.212]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.82]) with mapi id 14.03.0248.002; Thu, 30 Mar 2017 15:52:35 +0800 From: "Dong, Eric" To: "Long, Qin" , "Ye, Ting" , "Wu, Hao A" , "edk2-devel@lists.01.org" Thread-Topic: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module Thread-Index: AQHSqSnXOlAaworj7kSMCpdZcXA5hqGtArow Date: Thu, 30 Mar 2017 07:52:34 +0000 Message-ID: References: <20170330074644.10580-1-qin.long@intel.com> In-Reply-To: <20170330074644.10580-1-qin.long@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 07:52:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Long, Qin=20 Sent: Thursday, March 30, 2017 3:47 PM To: Ye, Ting; Dong, Eric; Wu, Hao A; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Mod= ule The memory free operation is empty function in PEI. The compiler optimizati= on will bring the build warning in openssl/crypto/mem.c: warning C4718: 'CRYPTO_free': recursive call has no side effects, deleting This patch uses '/wd4718' to silence the build warning for PEI module build= ing. Cc: Ting Ye Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Lib= rary/BaseCryptLib/PeiCryptLib.inf index fdcd8b95f5..34e18971c8 100644 --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf @@ -89,8 +89,9 @@ # # suppress the following warnings so we do not break the build with warn= ings-as-errors: # C4090: 'function' : different 'const' qualifiers + # C4717: 'function call' : recursive call has no side effects,=20 + deleting # - MSFT:*_*_*_CC_FLAGS =3D /wd4090 + MSFT:*_*_*_CC_FLAGS =3D /wd4090 /wd4718 =20 GCC:*_GCC44_IA32_CC_FLAGS =3D "-D__cdecl=3D__attribute__((cdecl))" "-D__= declspec(t)=3D__attribute__((t))" =20 -- 2.12.2.windows.1