* [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module
@ 2017-03-30 7:46 Qin Long
2017-03-30 7:52 ` Dong, Eric
2017-03-30 7:56 ` Ye, Ting
0 siblings, 2 replies; 3+ messages in thread
From: Qin Long @ 2017-03-30 7:46 UTC (permalink / raw)
To: ting.ye, eric.dong, hao.a.wu, edk2-devel
The memory free operation is empty function in PEI. The compiler
optimization will bring the build warning in openssl/crypto/mem.c:
warning C4718: 'CRYPTO_free': recursive call has no side
effects, deleting
This patch uses '/wd4718' to silence the build warning for PEI
module building.
Cc: Ting Ye <ting.ye@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
---
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
index fdcd8b95f5..34e18971c8 100644
--- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
+++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
@@ -89,8 +89,9 @@
#
# suppress the following warnings so we do not break the build with warnings-as-errors:
# C4090: 'function' : different 'const' qualifiers
+ # C4717: 'function call' : recursive call has no side effects, deleting
#
- MSFT:*_*_*_CC_FLAGS = /wd4090
+ MSFT:*_*_*_CC_FLAGS = /wd4090 /wd4718
GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "-D__declspec(t)=__attribute__((t))"
--
2.12.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module
2017-03-30 7:46 [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module Qin Long
@ 2017-03-30 7:52 ` Dong, Eric
2017-03-30 7:56 ` Ye, Ting
1 sibling, 0 replies; 3+ messages in thread
From: Dong, Eric @ 2017-03-30 7:52 UTC (permalink / raw)
To: Long, Qin, Ye, Ting, Wu, Hao A, edk2-devel@lists.01.org
Reviewed-by: Eric Dong <eric.dong@intel.com>
-----Original Message-----
From: Long, Qin
Sent: Thursday, March 30, 2017 3:47 PM
To: Ye, Ting; Dong, Eric; Wu, Hao A; edk2-devel@lists.01.org
Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module
The memory free operation is empty function in PEI. The compiler optimization will bring the build warning in openssl/crypto/mem.c:
warning C4718: 'CRYPTO_free': recursive call has no side
effects, deleting
This patch uses '/wd4718' to silence the build warning for PEI module building.
Cc: Ting Ye <ting.ye@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
---
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
index fdcd8b95f5..34e18971c8 100644
--- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
+++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
@@ -89,8 +89,9 @@
#
# suppress the following warnings so we do not break the build with warnings-as-errors:
# C4090: 'function' : different 'const' qualifiers
+ # C4717: 'function call' : recursive call has no side effects,
+ deleting
#
- MSFT:*_*_*_CC_FLAGS = /wd4090
+ MSFT:*_*_*_CC_FLAGS = /wd4090 /wd4718
GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "-D__declspec(t)=__attribute__((t))"
--
2.12.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module
2017-03-30 7:46 [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module Qin Long
2017-03-30 7:52 ` Dong, Eric
@ 2017-03-30 7:56 ` Ye, Ting
1 sibling, 0 replies; 3+ messages in thread
From: Ye, Ting @ 2017-03-30 7:56 UTC (permalink / raw)
To: Long, Qin, Dong, Eric, Wu, Hao A, edk2-devel@lists.01.org
Reviewed-by: Ye Ting <ting.ye@intel.com>
-----Original Message-----
From: Long, Qin
Sent: Thursday, March 30, 2017 3:47 PM
To: Ye, Ting <ting.ye@intel.com>; Dong, Eric <eric.dong@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; edk2-devel@lists.01.org
Subject: [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module
The memory free operation is empty function in PEI. The compiler optimization will bring the build warning in openssl/crypto/mem.c:
warning C4718: 'CRYPTO_free': recursive call has no side
effects, deleting
This patch uses '/wd4718' to silence the build warning for PEI module building.
Cc: Ting Ye <ting.ye@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com>
---
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
index fdcd8b95f5..34e18971c8 100644
--- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
+++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
@@ -89,8 +89,9 @@
#
# suppress the following warnings so we do not break the build with warnings-as-errors:
# C4090: 'function' : different 'const' qualifiers
+ # C4717: 'function call' : recursive call has no side effects,
+ deleting
#
- MSFT:*_*_*_CC_FLAGS = /wd4090
+ MSFT:*_*_*_CC_FLAGS = /wd4090 /wd4718
GCC:*_GCC44_IA32_CC_FLAGS = "-D__cdecl=__attribute__((cdecl))" "-D__declspec(t)=__attribute__((t))"
--
2.12.2.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-30 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 7:46 [Patch] CryptoPkg/BaseCryptLib: Fix Build Warning issue in PEI Module Qin Long
2017-03-30 7:52 ` Dong, Eric
2017-03-30 7:56 ` Ye, Ting
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox