From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70B4221A1349E for ; Tue, 9 May 2017 23:45:13 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2017 23:45:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,318,1491289200"; d="scan'208";a="100193126" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 09 May 2017 23:45:13 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 May 2017 23:45:12 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 May 2017 23:45:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.193]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Wed, 10 May 2017 14:45:09 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [patch] MdeModulePkg/FormDisplay: Make the LineWidth of option consistent Thread-Index: AQHSyVXEqTbqaIORnkGiGh12H7PEPqHtHxfw Date: Wed, 10 May 2017 06:45:08 +0000 Message-ID: References: <1494397284-256496-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1494397284-256496-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/FormDisplay: Make the LineWidth of option consistent X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 06:45:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Bi, Dandan=20 Sent: Wednesday, May 10, 2017 2:21 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming Subject: [patch] MdeModulePkg/FormDisplay: Make the LineWidth of option con= sistent REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D529 LineWidth of option in funcrion UpdateSkipInfoForMenu and DisplayOneMenu ar= e inconsistent. Now fix this issue to avoid incorrect UI display. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeMod= ulePkg/Universal/DisplayEngineDxe/FormDisplay.c index e1ac5a3..dc4ae4b 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c @@ -875,11 +875,11 @@ UpdateSkipInfoForMenu ( UINT16 Width; UINTN Row; CHAR16 *OutputString; UINT16 GlyphWidth; =20 - Width =3D (UINT16) gOptionBlockWidth; + Width =3D (UINT16) gOptionBlockWidth - 1; GlyphWidth =3D 1; Row =3D 1; =20 for (Index =3D 0; GetLineByWidth (OptionString, Width, &GlyphWidth, &Ind= ex, &OutputString) !=3D 0x0000;) { if (StrLen (&OptionString[Index]) !=3D 0) { -- 1.9.5.msysgit.1