From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E5EF221BB253B for ; Mon, 12 Jun 2017 19:07:42 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 12 Jun 2017 19:08:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,336,1493708400"; d="scan'208";a="98707022" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2017 19:08:55 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 19:08:55 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 12 Jun 2017 19:08:54 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Tue, 13 Jun 2017 10:08:53 +0800 From: "Dong, Eric" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [patch] MdeModulePkg/BMMUiLib: Fix incorrect variable name Thread-Index: AQHS4x4XGamZwscW/ESXBxhW/tkwz6IiDajQ Date: Tue, 13 Jun 2017 02:08:52 +0000 Message-ID: References: <1497232137-344844-1-git-send-email-dandan.bi@intel.com> In-Reply-To: <1497232137-344844-1-git-send-email-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/BMMUiLib: Fix incorrect variable name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2017 02:07:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: Bi, Dandan=20 Sent: Monday, June 12, 2017 9:49 AM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [patch] MdeModulePkg/BMMUiLib: Fix incorrect variable name REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D592 In function UpdateConsoleContent, we compare console name with "ErrOut" str= ing to check whether the content in console Error device page has been chan= ged. But when call function UpdateConsoleContent, we pass console name as "= ConErr" by mistake. This patch is to fix the inconsistent issue. Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenan= ce.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c index 3ff23a5..98e14c7 100644 --- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c +++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c @@ -1300,11 +1300,11 @@ BootMaintCallback ( if ((QuestionId >=3D CON_IN_DEVICE_QUESTION_ID) && (QuestionId < CON_I= N_DEVICE_QUESTION_ID + MAX_MENU_NUMBER)) { UpdateConsoleContent (L"ConIn",CurrentFakeNVMap); } else if ((QuestionId >=3D CON_OUT_DEVICE_QUESTION_ID) && (QuestionId= < CON_OUT_DEVICE_QUESTION_ID + MAX_MENU_NUMBER)) { UpdateConsoleContent (L"ConOut", CurrentFakeNVMap); } else if ((QuestionId >=3D CON_ERR_DEVICE_QUESTION_ID) && (QuestionId= < CON_ERR_DEVICE_QUESTION_ID + MAX_MENU_NUMBER)) { - UpdateConsoleContent (L"ConErr", CurrentFakeNVMap); + UpdateConsoleContent (L"ErrOut", CurrentFakeNVMap); } } =20 // // Pass changed uncommitted data back to Form Browser -- 1.9.5.msysgit.1