From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 330F121E1452B for ; Wed, 16 Aug 2017 23:45:21 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2017 23:47:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,386,1498546800"; d="scan'208";a="301256795" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 16 Aug 2017 23:47:47 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 Aug 2017 23:47:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.183]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.236]) with mapi id 14.03.0319.002; Thu, 17 Aug 2017 14:47:45 +0800 From: "Dong, Eric" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Gao, Liming" , "Dong, Eric" Thread-Topic: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. Thread-Index: AQHTFM47sJKwIRcNVkmNNRmPVoJfT6KGoWMAgAF7PvA= Date: Thu, 17 Aug 2017 06:47:43 +0000 Message-ID: References: <1502695374-11368-1-git-send-email-eric.dong@intel.com> <1502695374-11368-2-git-send-email-eric.dong@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Aug 2017 06:45:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Processor trace feature need to get three inputs from end user. 1. Enabe/d= isable, 2. Memory size, 3, Output scheme.=20 It will have three menus in UI to let end user to select. I want the defaul= t value for all three menus are disabled, so I add invalid or disable for b= oth PCDs. Maybe I can enhance OutputSchemeInvalid to OutputSchemeDisable fo= r consistent with EnumProcTraceMemDisable. For the BITxx issue, I have submit a patch for it, please help to review it= . Thanks, Eric -----Original Message----- From: Kinney, Michael D=20 Sent: Wednesday, August 16, 2017 11:59 PM To: Dong, Eric ; edk2-devel@lists.01.org; Kinney, Mich= ael D Cc: Ni, Ruiyu ; Gao, Liming Subject: RE: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definitio= n. Eric, For the PCD PcdCpuProcTraceOutputScheme, the description of "Invalid scheme= " does not seem like a good description for disable. Do we really need the value 0x02 for PcdCpuProcTraceOutputScheme at all? Can we use PcdCpuFeaturesSetting set to 0x10 ProcTraceMemDisable to know th= at the feature is disabled, and only look at PcdCpuProcTraceOutputScheme if= PcdCpuFeaturesSetting is set to a value where the memory size is > 0? Also, when looking at where these PCD values are used in UefiCpuPkg\Library= \CpuCommonFeaturesLib\ProcTrace.c, I see use of BITxx to modify the MSR_IA3= 2_RTIT_CTL values. Please use the bit fields in the MSR_IA32_RTIT_CTL_REGI= STER structure instead. You can work on this change as a separate patch. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Eric Dong > Sent: Monday, August 14, 2017 12:23 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D=20 > ; Gao, Liming > Subject: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs=20 > definition. >=20 > Add valid/default values for PCD PcdCpuProcTraceMemSize and=20 > PcdCpuProcTraceOutputScheme in the comment part. >=20 > Cc: Liming Gao > Cc: Ruiyu Ni > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/UefiCpuPkg.dec | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec=20 > index 2ddeab4..b4e099d 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -285,12 +285,36 @@ > # @ValidList 0x80000001 | 0 > gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, 0x00,=20 > 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 >=20 > - ## Contains the size of memory required when CPU processor trace is=20 > enabled. > + ## Contains the size of memory required when CPU processor > trace is enabled.

> + # Default value is 0x10 which disables the processor > trace.
> + # 0x0 - 4K.
> + # 0x1 - 8K.
> + # 0x2 - 16K.
> + # 0x3 - 32K.
> + # 0x4 - 64K.
> + # 0x5 - 128K.
> + # 0x6 - 256K.
> + # 0x7 - 512K.
> + # 0x8 - 1M.
> + # 0x9 - 2M.
> + # 0xA - 4M.
> + # 0xB - 8M.
> + # 0xC - 16M.
> + # 0xD - 32M.
> + # 0xE - 64M.
> + # 0xF - 128M.
> + # 0x10 - ProcTraceMemDisable.
> # @Prompt The memory size used for processor trace. > + # @ValidRange 0x80000001 | 0 - 0x10 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x6 > 0000012 >=20 > - ## Contains the processor trace output scheme when CPU processor=20 > trace is enabled. > + ## Contains the processor trace output scheme when CPU > processor trace is enabled.

> + # Default value is 2 which disables the processor trace.
# 0=20 > + - Single Range output scheme.
# 1 - ToPA(Table of physical=20 > + address) scheme.
# 2 - Invalid scheme.
> # @Prompt The processor trace output scheme. > + # @ValidRange 0x80000001 | 0 - 2 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8| > 0x60000015 >=20 > [UserExtensions.TianoCore."ExtraFiles"] > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel