From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 25EF321E87962 for ; Tue, 12 Sep 2017 23:06:24 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 12 Sep 2017 23:09:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,386,1500966000"; d="scan'208";a="1218117831" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 12 Sep 2017 23:09:20 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Sep 2017 23:09:18 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.39]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Wed, 13 Sep 2017 14:09:06 +0800 From: "Dong, Eric" To: "Bi, Dandan" CC: "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] [edk2-VfrSpecification PATCH] Add union data type and bit fields in VFR Data Struct Definition Thread-Index: AQHTJVmGKy2m/1JhlEK/TY7pVqAjaaKx2+2AgACGqxA= Date: Wed, 13 Sep 2017 06:09:05 +0000 Message-ID: References: <1504514347-352780-1-git-send-email-dandan.bi@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3B970181@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3B970181@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [edk2-VfrSpecification PATCH] Add union data type and bit fields in VFR Data Struct Definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 06:06:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dand= an Bi Sent: Monday, September 04, 2017 4:39 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming Subject: [edk2] [edk2-VfrSpecification PATCH] Add union data type and bit f= ields in VFR Data Struct Definition https://bugzilla.tianocore.org/show_bug.cgi?id=3D683 Cc: Eric Dong Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- .../23_vfr_data_struct_definition.md | 39 ++++++++++++++++++= ++++ README.md | 1 + 2 files changed, 40 insertions(+) diff --git a/2_vfr_description_in_bnf/23_vfr_data_struct_definition.md b/2_= vfr_description_in_bnf/23_vfr_data_struct_definition.md index 6d6730d..4937e6a 100644 --- a/2_vfr_description_in_bnf/23_vfr_data_struct_definition.md +++ b/2_vfr_description_in_bnf/23_vfr_data_struct_definition.md @@ -36,10 +36,16 @@ vfrDataStructDefinition ::=3D { "typedef" } "struct" { StringIdentifier } "{" vfrDataStructFields "}" { StringIdentifier } ";" =20 +vfrDataStructDefinition ::=3D + { "typedef" } "union" + { StringIdentifier } + "{" vfrDataStructFields "}" + { StringIdentifier } ";" + vfrDataStructFields ::=3D ( dataStructField64 | dataStructField32 | dataStructField16 @@ -48,10 +54,14 @@ vfrDataStructFields ::=3D | dataStructFieldString | dataStructFieldDate | dataStructFieldTime | dataStructFieldRef | dataStructFieldUser + | dataStructBitField64 + | dataStructBitField32 + | dataStructBitField16 + | dataStructBitField8 )* =20 dataStructField64 ::=3D "UINT64" StringIdentifier { "[" Number "]" } ";" @@ -89,10 +99,26 @@ dataStructFieldRef ::=3D StringIdentifier { "[" Number "]" } ";" =20 dataStructFieldUser ::=3D StringIdentifier StringIdentifier { "[" Number "]" } ";" + +dataStructBitField64 ::=3D + "UINT64" + { StringIdentifier } ":" Number ";" + +dataStructBitField32 ::=3D + "UINT32" + { StringIdentifier } ":" Number ";" + +dataStructBitField16 ::=3D + "UINT16" + { StringIdentifier } ":" Number ";" + +dataStructBitField8 ::=3D + "UINT8" + { StringIdentifier } ":" Number ";" ``` =20 #### BEHAVIORS AND RESTRICTIONS =20 The data structure definition is in C-style language. `enum` type is not @= @ -108,10 +134,23 @@ typedef struct { UINT8 mU8; UINT16 mU16; UINT32 mU32[10]; UINT64 mU64; } MyData; + +typedef union { + UINT16 Field16; + UINT8 Field8; +} MyUnionData; + +typedef struct { + UINT16 Field16; + UINT8 MyBits1 : 1; + UINT8 MyBits2 : 3; + UINT8 MyBits3 : 3; + UINT16 MyBits4 : 4; +} MyBitsData; ``` =20 **Unsupported Example of enum type:** =20 ```c diff --git a/README.md b/README.md index 888eb81..0a596eb 100644 --- a/README.md +++ b/README.md @@ -89,5 +89,6 @@ Copyright (c) 2007-2017, Intel Corporation. All rights re= served. | 1.60 | Update syntax for goto, image, questionref and constant value= opcodes, correct CALLBACK flag to INTEREACTIVE, correct help string for ol= d syntax date/time example, and add examples for expression opcodes. | De= cember 1, 2011 | | 1.70 | Clarify restriction that enum type and struct data filed with= more than one dimensions array are not supported. = | Ma= y 18, 2012 | | 1.80 | Add syntax for warningif opcode, update definition for name/v= alue varstore and subtitle opcode, update referenced UEFI spec version info= . | Ja= n 14, 2014 | | 1.90 | Correct sample code for catenate/match/cond opcode. Add synta= x for match2 opcode. Add sample code to show the buffer type constant value= for orderedlist opcode and default opcode. | Ju= ly 2, 2015 | | 1.91 | Convert to Gitbook = = | Ap= ril 2017 | +| | [#683](https://bugzilla.tianocore.org/show_bug.cgi?id=3D683) = VFR Spec: Add union data type and bit fields in VFR Data Struct Definition = | = | -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel