From: "Dong, Eric" <eric.dong@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for Mem32/Mem64
Date: Thu, 19 Oct 2017 02:51:46 +0000 [thread overview]
Message-ID: <ED077930C258884BBCB450DB737E66224AA3989E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20171019024903.356092-1-ruiyu.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Thursday, October 19, 2017 10:49 AM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for
> Mem32/Mem64
>
> Existing code forgot to set Descriptor->SpecificFlag to 0 when the resource
> type is non-prefetchable MMIO.
> The patch adds the missing assignment.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> index 70726a6be8..1494848c3e 100644
> --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> @@ -2,7 +2,7 @@
>
> Provides the basic interfaces to abstract a PCI Host Bridge Resource
> Allocation.
>
> -Copyright (c) 1999 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 1999 - 2017, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License which
> accompanies this distribution. The full text of the license may be found at
> @@ -574,7 +574,8 @@ ResourceConflict (
> Descriptor->Len = sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3;
> Descriptor->AddrRangeMin = ResAllocNode->Base;
> Descriptor->AddrRangeMax = ResAllocNode->Alignment;
> - Descriptor->AddrLen = ResAllocNode->Length;
> + Descriptor->AddrLen = ResAllocNode->Length;
> + Descriptor->SpecificFlag = 0;
> switch (ResAllocNode->Type) {
>
> case TypeIo:
> --
> 2.12.2.windows.2
prev parent reply other threads:[~2017-10-19 2:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 2:49 [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for Mem32/Mem64 Ruiyu Ni
2017-10-19 2:51 ` Dong, Eric [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED077930C258884BBCB450DB737E66224AA3989E@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox