From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=eric.dong@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 760D121E7821E for ; Wed, 18 Oct 2017 19:48:15 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2017 19:51:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,399,1503385200"; d="scan'208";a="164812195" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 18 Oct 2017 19:51:50 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 19:51:50 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Oct 2017 19:51:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Thu, 19 Oct 2017 10:51:47 +0800 From: "Dong, Eric" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for Mem32/Mem64 Thread-Index: AQHTSITcYwrwumCLMU2WPondEeDT1qLqeUoA Date: Thu, 19 Oct 2017 02:51:46 +0000 Message-ID: References: <20171019024903.356092-1-ruiyu.ni@intel.com> In-Reply-To: <20171019024903.356092-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for Mem32/Mem64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 02:48:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong > -----Original Message----- > From: Ni, Ruiyu > Sent: Thursday, October 19, 2017 10:49 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: [PATCH] MdeModulePkg/PciHostBridge: Set SpecificFlag to 0 for > Mem32/Mem64 >=20 > Existing code forgot to set Descriptor->SpecificFlag to 0 when the resour= ce > type is non-prefetchable MMIO. > The patch adds the missing assignment. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Eric Dong > --- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > index 70726a6be8..1494848c3e 100644 > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > @@ -2,7 +2,7 @@ >=20 > Provides the basic interfaces to abstract a PCI Host Bridge Resource > Allocation. >=20 > -Copyright (c) 1999 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 1999 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License which > accompanies this distribution. The full text of the license may be found= at > @@ -574,7 +574,8 @@ ResourceConflict ( > Descriptor->Len =3D sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3= ; > Descriptor->AddrRangeMin =3D ResAllocNode->Base; > Descriptor->AddrRangeMax =3D ResAllocNode->Alignment; > - Descriptor->AddrLen =3D ResAllocNode->Length; > + Descriptor->AddrLen =3D ResAllocNode->Length; > + Descriptor->SpecificFlag =3D 0; > switch (ResAllocNode->Type) { >=20 > case TypeIo: > -- > 2.12.2.windows.2